Skip to content

Commit 2f7c197

Browse files
committed
Updated the edit_policy.js test cases to accept 0 timing phase
1 parent 1827fab commit 2f7c197

1 file changed

Lines changed: 6 additions & 7 deletions

File tree

x-pack/legacy/plugins/index_lifecycle_management/__jest__/components/edit_policy.test.js

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ import sinon from 'sinon';
2020
import { findTestSubject } from '@elastic/eui/lib/test';
2121
import {
2222
positiveNumbersAboveZeroErrorMessage,
23-
positiveNumbersEqualAboveZeroErrorMessage,
2423
positiveNumberRequiredMessage,
2524
maximumAgeRequiredMessage,
2625
maximumSizeRequiredMessage,
@@ -238,14 +237,14 @@ describe('edit policy', () => {
238237
});
239238
});
240239
describe('warm phase', () => {
241-
test('', () => {
240+
test('should allow 0 for phase timing', () => {
242241
const rendered = mountWithIntl(component);
243242
noRollover(rendered);
244243
setPolicyName(rendered, 'mypolicy');
245244
activatePhase(rendered, 'warm');
246245
setPhaseAfter(rendered, 'warm', 0);
247246
save(rendered);
248-
expectedErrorMessages(rendered, [positiveNumbersEqualAboveZeroErrorMessage]);
247+
expectedErrorMessages(rendered, []);
249248
});
250249
test('should show positive number required error when trying to save warm phase with -1 for after', () => {
251250
const rendered = mountWithIntl(component);
@@ -375,14 +374,14 @@ describe('edit policy', () => {
375374
});
376375
});
377376
describe('cold phase', () => {
378-
test('', () => {
377+
test('should allow 0 for phase timing', () => {
379378
const rendered = mountWithIntl(component);
380379
noRollover(rendered);
381380
setPolicyName(rendered, 'mypolicy');
382381
activatePhase(rendered, 'cold');
383382
setPhaseAfter(rendered, 'cold', 0);
384383
save(rendered);
385-
expectedErrorMessages(rendered, [positiveNumbersEqualAboveZeroErrorMessage]);
384+
expectedErrorMessages(rendered, []);
386385
});
387386
test('should show positive number required error when trying to save cold phase with -1 for after', () => {
388387
const rendered = mountWithIntl(component);
@@ -456,14 +455,14 @@ describe('edit policy', () => {
456455
});
457456
});
458457
describe('delete phase', () => {
459-
test('', () => {
458+
test('should allow 0 for phase timing', () => {
460459
const rendered = mountWithIntl(component);
461460
noRollover(rendered);
462461
setPolicyName(rendered, 'mypolicy');
463462
activatePhase(rendered, 'delete');
464463
setPhaseAfter(rendered, 'delete', 0);
465464
save(rendered);
466-
expectedErrorMessages(rendered, [positiveNumbersEqualAboveZeroErrorMessage]);
465+
expectedErrorMessages(rendered, []);
467466
});
468467
test('should show positive number required error when trying to save delete phase with -1 for after', () => {
469468
const rendered = mountWithIntl(component);

0 commit comments

Comments
 (0)