Skip to content

Commit 2f5d14a

Browse files
paul-tavarespaul-tavares
committed
Merge remote-tracking branch 'kpollich/fleet/enable-space-awareness-flag' into fork/kpollich/fleet/enable-space-awareness-flag
2 parents 2aba14b + 7303d73 commit 2f5d14a

163 files changed

Lines changed: 1410 additions & 430 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.buildkite/ftr_platform_stateful_configs.yml‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,13 @@ disabled:
3030
- x-pack/platform/test/alerting_api_integration/security_and_spaces/group2/tests/telemetry/config.ts
3131
- x-pack/platform/test/alerting_api_integration/spaces_only_legacy/config.ts
3232
- x-pack/test/cloud_integration/config.ts
33-
- x-pack/test/load/config.ts
34-
- x-pack/test/plugin_api_perf/config.js
33+
- x-pack/platform/test/load/config.ts
34+
- x-pack/platform/test/plugin_api_perf/config.ts
3535
- x-pack/test/screenshot_creation/config.ts
36-
- x-pack/test/fleet_packages/config.ts
36+
- x-pack/platform/test/fleet_packages/config.ts
3737

3838
# Scalability testing config that we run in its own pipeline
39-
- x-pack/test/scalability/config.ts
39+
- x-pack/platform/test/scalability/config.ts
4040

4141
# Cypress configs, for now these are still run manually
4242
- x-pack/test/fleet_cypress/cli_config.ts
@@ -173,8 +173,8 @@ enabled:
173173
- x-pack/test/fleet_api_integration/config.package_policy.ts
174174
- x-pack/test/fleet_api_integration/config.space_awareness.ts
175175
- x-pack/test/fleet_functional/config.ts
176-
- x-pack/test/fleet_tasks/config.ts
177-
- x-pack/test/ftr_apis/security_and_spaces/config.ts
176+
- x-pack/platform/test/fleet_tasks/config.ts
177+
- x-pack/platform/test/ftr_apis/security_and_spaces/config.ts
178178
- x-pack/test/functional_basic/apps/ml/permissions/config.ts
179179
- x-pack/test/functional_basic/apps/ml/data_visualizer/group1/config.ts
180180
- x-pack/test/functional_basic/apps/ml/data_visualizer/group2/config.ts
@@ -330,7 +330,7 @@ enabled:
330330
- x-pack/test/spaces_api_integration/security_and_spaces/config_basic.ts
331331
- x-pack/test/spaces_api_integration/security_and_spaces/config_trial.ts
332332
- x-pack/test/spaces_api_integration/spaces_only/config.ts
333-
- x-pack/test/task_manager_claimer_update_by_query/config.ts
333+
- x-pack/platform/test/task_manager_claimer_update_by_query/config.ts
334334
- x-pack/test/ui_capabilities/security_and_spaces/config.ts
335335
- x-pack/test/ui_capabilities/spaces_only/config.ts
336336
- x-pack/test/upgrade_assistant_integration/config.ts

‎.buildkite/scripts/pipelines/pull_request/pipeline.ts‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,13 +197,14 @@ const getPipeline = (filename: string, removeSteps = true) => {
197197
}
198198

199199
if (
200-
(await doAnyChangesMatch([
200+
((await doAnyChangesMatch([
201201
/\.docnav\.json$/,
202202
/\.apidocs\.json$/,
203203
/\.devdocs\.json$/,
204204
/\.mdx$/,
205205
/^dev_docs\/.*(png|gif|jpg|jpeg|webp)$/,
206-
])) ||
206+
])) &&
207+
process.env.GITHUB_PR_TARGET_BRANCH === 'main') ||
207208
GITHUB_PR_LABELS.includes('ci:build-next-docs')
208209
) {
209210
pipeline.push(getPipeline('.buildkite/pipelines/pull_request/check_next_docs.yml'));

‎.buildkite/scripts/steps/fleet/install_all_packages.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ echo '--- Installing all packages'
99
node scripts/functional_tests \
1010
--debug \
1111
--bail \
12-
--config x-pack/test/fleet_packages/config.ts
12+
--config x-pack/platform/test/fleet_packages/config.ts

‎.buildkite/scripts/steps/scalability/api_capacity_testing.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ checkout_and_compile_load_runner
2222

2323
echo "--- Run single apis capacity tests"
2424
cd "$KIBANA_DIR"
25-
node scripts/run_scalability --kibana-install-dir "$KIBANA_BUILD_LOCATION" --journey-path "x-pack/test/scalability/apis"
25+
node scripts/run_scalability --kibana-install-dir "$KIBANA_BUILD_LOCATION" --journey-path "x-pack/platform/test/scalability/apis"
2626

2727
echo "--- Upload test results"
2828
upload_test_results

‎.github/CODEOWNERS‎

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -982,7 +982,9 @@ x-pack/platform/test/plugin_api_integration/plugins/elasticsearch_client @elasti
982982
x-pack/platform/test/plugin_api_integration/plugins/event_log @elastic/response-ops
983983
x-pack/platform/test/plugin_api_integration/plugins/feature_usage_test @elastic/kibana-security
984984
x-pack/platform/test/plugin_api_integration/plugins/sample_task_plugin @elastic/response-ops
985+
x-pack/platform/test/plugin_api_perf/plugins/task_manager_performance @elastic/response-ops
985986
x-pack/platform/test/saved_object_api_integration/common/plugins/saved_object_test_plugin @elastic/kibana-security
987+
x-pack/platform/test/task_manager_claimer_update_by_query/plugins/sample_task_plugin_mget @elastic/response-ops
986988
x-pack/solutions/chat/packages/wc-framework-types-browser @elastic/search-kibana @elastic/workchat-eng
987989
x-pack/solutions/chat/packages/wc-framework-types-common @elastic/search-kibana @elastic/workchat-eng
988990
x-pack/solutions/chat/packages/wc-framework-types-server @elastic/search-kibana @elastic/workchat-eng
@@ -1103,7 +1105,6 @@ x-pack/test/functional_execution_context/plugins/alerts @elastic/kibana-core
11031105
x-pack/test/functional_with_es_ssl/plugins/alerts @elastic/response-ops
11041106
x-pack/test/functional_with_es_ssl/plugins/cases @elastic/response-ops
11051107
x-pack/test/licensing_plugin/plugins/test_feature_usage @elastic/kibana-security
1106-
x-pack/test/plugin_api_perf/plugins/task_manager_performance @elastic/response-ops
11071108
x-pack/test/plugin_functional/plugins/global_search_test @elastic/kibana-core
11081109
x-pack/test/plugin_functional/plugins/resolver_test @elastic/security-solution
11091110
x-pack/test/security_api_integration/packages/helpers @elastic/kibana-security
@@ -1114,7 +1115,6 @@ x-pack/test/security_api_integration/plugins/saml_provider @elastic/kibana-secur
11141115
x-pack/test/security_api_integration/plugins/user_profiles_consumer @elastic/kibana-security
11151116
x-pack/test/security_functional/plugins/test_endpoints @elastic/kibana-security
11161117
x-pack/test/spaces_api_integration/common/plugins/spaces_test_plugin @elastic/kibana-security
1117-
x-pack/test/task_manager_claimer_update_by_query/plugins/sample_task_plugin_mget @elastic/response-ops
11181118
x-pack/test/ui_capabilities/common/plugins/foo_plugin @elastic/kibana-security
11191119
x-pack/test/usage_collection/plugins/application_usage_test @elastic/kibana-core
11201120
x-pack/test/usage_collection/plugins/stack_management_usage_test @elastic/kibana-management
@@ -1477,8 +1477,8 @@ src/platform/plugins/shared/discover/public/context_awareness/profile_providers/
14771477
/x-pack/test/functional/es_archives/fleet @elastic/fleet
14781478
/x-pack/test/api_integration/services/fleet_and_agents.ts @elastic/fleet
14791479
/x-pack/test/fleet_api_integration @elastic/fleet
1480-
/x-pack/test/fleet_packages @elastic/fleet
1481-
/x-pack/test/fleet_tasks @elastic/fleet
1480+
/x-pack/platform/test/fleet_packages @elastic/fleet
1481+
/x-pack/platform/test/fleet_tasks @elastic/fleet
14821482
/src/platform/test/api_integration/apis/custom_integration/*.ts @elastic/fleet
14831483
/x-pack/test/fleet_cypress @elastic/fleet
14841484
/x-pack/test/fleet_functional @elastic/fleet
@@ -1696,6 +1696,7 @@ x-pack/platform/plugins/shared/ml/server/models/data_recognizer/modules/security
16961696
# QA - Appex QA
16971697
.buildkite/scout_ci_config.yml @elastic/appex-qa
16981698
/x-pack/test/.gitignore @elastic/appex-qa
1699+
/x-pack/platform/test/index.d.ts @elastic/appex-qa
16991700
/src/platform/packages/shared/kbn-es/src/serverless_resources/project_roles/es/roles.yml @elastic/appex-qa
17001701
/src/platform/packages/shared/kbn-es/src/serverless_resources/project_roles/oblt/roles.yml @elastic/appex-qa
17011702
/src/platform/packages/shared/kbn-es/src/serverless_resources/project_roles/security/roles.yml @elastic/appex-qa
@@ -1766,7 +1767,7 @@ x-pack/platform/plugins/shared/ml/server/models/data_recognizer/modules/security
17661767
/x-pack/platform/test/api_integration/services @elastic/appex-qa
17671768
/x-pack/platform/test/api_integration/apis/kibana/config.ts @elastic/appex-qa
17681769
/x-pack/test/tsconfig.json @elastic/appex-qa
1769-
/x-pack/test/load @elastic/appex-qa
1770+
/x-pack/platform/test/load @elastic/appex-qa
17701771
/src/platform/test/tsconfig.json @elastic/appex-qa
17711772
/src/platform/test/plugin_functional/services/index.ts @elastic/appex-qa
17721773
/src/platform/test/plugin_functional/README.md @elastic/appex-qa
@@ -1818,7 +1819,7 @@ x-pack/platform/plugins/shared/ml/server/models/data_recognizer/modules/security
18181819
/src/platform/test/accessibility/ftr_provider_context.ts @elastic/appex-qa
18191820
/src/platform/test/accessibility/config.ts @elastic/appex-qa
18201821
/src/platform/test/accessibility/apps/index.ts @elastic/appex-qa
1821-
/x-pack/test/scalability @elastic/appex-qa
1822+
/x-pack/platform/test/scalability @elastic/appex-qa
18221823
/src/dev/performance @elastic/appex-qa
18231824
/x-pack/test/functional/config.*.* @elastic/appex-qa
18241825
/x-pack/platform/test/functional/config.*.* @elastic/appex-qa
@@ -2017,9 +2018,9 @@ x-pack/platform/plugins/private/cloud_integrations/cloud_full_story/server/confi
20172018
/x-pack/test/functional/es_archives/security @elastic/kibana-security
20182019
/x-pack/test/functional/fixtures/kbn_archiver/spaces @elastic/kibana-security
20192020
/x-pack/test/functional/fixtures/kbn_archiver/security @elastic/kibana-security
2020-
/x-pack/test/ftr_apis/common/lib @elastic/kibana-security
2021-
/x-pack/test/ftr_apis/common/fixtures/es_archiver/base_data/space_1.json @elastic/kibana-security # Assigned per only use: https://github.com/elastic/kibana/blob/main/x-pack/test/ftr_apis/security_and_spaces/apis/test_utils.ts#L33
2022-
/x-pack/test/ftr_apis/common/fixtures/es_archiver/base_data/default_space.json @elastic/kibana-security # Assigned per only use: https://github.com/elastic/kibana/blob/main/x-pack/test/ftr_apis/security_and_spaces/apis/test_utils.ts#L33
2021+
/x-pack/platform/test/ftr_apis/common/lib @elastic/kibana-security
2022+
/x-pack/platform/test/ftr_apis/common/fixtures/es_archiver/base_data/space_1.json @elastic/kibana-security # Assigned per only use: https://github.com/elastic/kibana/blob/main/x-pack/platform/test/ftr_apis/security_and_spaces/apis/test_utils.ts#L33
2023+
/x-pack/platform/test/ftr_apis/common/fixtures/es_archiver/base_data/default_space.json @elastic/kibana-security # Assigned per only use: https://github.com/elastic/kibana/blob/main/x-pack/platform/test/ftr_apis/security_and_spaces/apis/test_utils.ts#L33
20232024
/x-pack/platform/test/api_integration/apis/cloud @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/198444
20242025
/src/platform/test/plugin_functional/snapshots/baseline/hardening @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/190716
20252026
/src/platform/test/functional/page_objects/login_page.ts @elastic/kibana-security
@@ -2036,7 +2037,7 @@ x-pack/platform/plugins/private/cloud_integrations/cloud_full_story/server/confi
20362037
/x-pack/test/common/services/spaces.ts @elastic/kibana-security
20372038
/x-pack/test/api_integration/config_security_*.ts @elastic/kibana-security
20382039
/x-pack/test/functional/apps/api_keys @elastic/kibana-security
2039-
/x-pack/test/ftr_apis/security_and_spaces @elastic/kibana-security
2040+
/x-pack/platform/test/ftr_apis/security_and_spaces @elastic/kibana-security
20402041
/src/platform/test/server_integration/services/supertest.js @elastic/kibana-security @elastic/kibana-core
20412042
/src/platform/test/server_integration/http/ssl @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810
20422043
/src/platform/test/server_integration/http/ssl_with_p12 @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/199795#discussion_r1846522206
@@ -2096,8 +2097,8 @@ x-pack/platform/plugins/private/cloud_integrations/cloud_full_story/server/confi
20962097
# Response Ops team
20972098
/x-pack/test/functional/es_archives/rule_registry @elastic/response-ops
20982099
/x-pack/test/functional/es_archives/event_log_multiple_indicies @elastic/response-ops
2099-
/x-pack/test/functional/es_archives/task_manager* @elastic/response-ops # Assigned per https://github.com/elastic/kibana/blob/assign-response-ops/x-pack/test/plugin_api_perf/plugins/task_manager_performance/kibana.jsonc#L4
2100-
/x-pack/test/plugin_api_perf @elastic/response-ops # Assigned per https://github.com/elastic/kibana/blob/assign-response-ops/x-pack/test/plugin_api_perf/plugins/task_manager_performance/kibana.jsonc#L4
2100+
/x-pack/test/functional/es_archives/task_manager* @elastic/response-ops # Assigned per https://github.com/elastic/kibana/blob/assign-response-ops/x-pack/platform/test/plugin_api_perf/plugins/task_manager_performance/kibana.jsonc#L4
2101+
/x-pack/platform/test/plugin_api_perf @elastic/response-ops # Assigned per https://github.com/elastic/kibana/blob/assign-response-ops/x-pack/platform/test/plugin_api_perf/plugins/task_manager_performance/kibana.jsonc#L4
21012102
/x-pack/test/functional/page_objects/maintenance_windows_page.ts @elastic/response-ops
21022103
/x-pack/test_serverless/functional/test_suites/observability/screenshot_creation/index.ts @elastic/response-ops
21032104
/x-pack/test_serverless/functional/test_suites/observability/rules/rules_list.ts @elastic/response-ops
@@ -2132,7 +2133,7 @@ x-pack/platform/plugins/private/cloud_integrations/cloud_full_story/server/confi
21322133
/x-pack/platform/test/plugin_api_integration/test_suites/task_manager/ @elastic/response-ops
21332134
/x-pack/test/functional_with_es_ssl/apps/embeddable_alerts_table/ @elastic/response-ops
21342135
/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/ @elastic/response-ops
2135-
/x-pack/test/task_manager_claimer_update_by_query/ @elastic/response-ops
2136+
/x-pack/platform/test/task_manager_claimer_update_by_query/ @elastic/response-ops
21362137
/docs/user/alerting/ @elastic/response-ops
21372138
/docs/management/connectors/ @elastic/response-ops
21382139
/x-pack/test/cases_api_integration/ @elastic/response-ops

‎dev_docs/tutorials/performance/adding_api_capacity_test.mdx‎

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,15 @@ tags: ['kibana', 'onboarding', 'setup', 'performance', 'development', 'telemetry
88
---
99

1010
## Overview
11+
1112
It is important to test individual API endpoint for the baseline performance, scalability, or breaking point. If an API doesn’t meet performance requirements, it is a bottleneck.
1213
This capacity tests track how response time changes while we slowly increase number of concurrent requests per second.
1314
While using similar load model, we are able to identify how many requests per second each endpoint can hold with response time staying below critical threshold.
1415

1516
Capacity API test defines 3 response time thresholds (default ones: 3000, 6000, 12000) in ms. Test results report rps (requests per second) for each threshold.
1617

1718
Test results are reported using EBT in the following format:
19+
1820
```json
1921
{
2022
"_index": "backing-kibana-server-scalability-metrics-000003",
@@ -37,7 +39,9 @@ Test results are reported using EBT in the following format:
3739
```
3840

3941
### Adding a new test
40-
Create a new json file in `x-pack/test/scalability/apis` with required properties:
42+
43+
Create a new json file in `x-pack/platform/test/scalability/apis` with required properties:
44+
4145
- **journeyName** is a test name, e.g. `GET /internal/security/session`
4246
- **scalabilitySetup** is used to set load model
4347
- **testData** is used to populate Elasticsearch and Kibana wth test data
@@ -47,13 +51,15 @@ Create a new json file in `x-pack/test/scalability/apis` with required propertie
4751
Warmup phase simulates 10 concurrent requests during 30s period and is important to get consistent results in test phase.
4852
Test phase simulates increasing concurrent requests from `minUsersCount` to `maxUsersCount` within `duration` time.
4953
Both `maxUsersCount` and `duration` in test phase should be adjusted for individual endpoint:
50-
- `maxUsersCount` should be reasonable and enough to reach endpoint limits
51-
- `duration` should be long enough to ramp up requests with low pace (1-2 requests per second)
54+
55+
- `maxUsersCount` should be reasonable and enough to reach endpoint limits
56+
- `duration` should be long enough to ramp up requests with low pace (1-2 requests per second)
5257

5358
Example:
59+
5460
```json
5561
{
56-
"journeyName": "GET /internal/security/session",
62+
"journeyName": "GET /internal/security/session",
5763
"scalabilitySetup": {
5864
"warmup": [
5965
{
@@ -99,6 +105,7 @@ Example:
99105
```
100106

101107
Override default response time thresholds by adding to `scalabilitySetup`:
108+
102109
```json
103110
"responseTimeThreshold": {
104111
"threshold1": 1000,
@@ -108,14 +115,16 @@ Override default response time thresholds by adding to `scalabilitySetup`:
108115
```
109116

110117
### Running api capacity journey locally
118+
111119
Clone [kibana-load-testing](https://github.com/elastic/kibana-load-testing) repo.
112120

113121
Use the Node script from kibana root directory:
114-
`node scripts/run_scalability_cli.js --journey-path x-pack/test/scalability/apis/$YOUR_JOURNEY_NAME.ts`
122+
`node scripts/run_scalability_cli.js --journey-path x-pack/platform/test/scalability/apis/$YOUR_JOURNEY_NAME.ts`
115123

116124
Use `--kibana-install-dir` flag to test build
117125

118126
### Benchmarking performance on CI
127+
119128
In order to keep track on performance metrics stability, api capacity tests are run on main branch with a scheduled interval.
120129
Bare metal machine is used to produce results as stable and reproducible as possible.
121130

@@ -128,6 +137,7 @@ RAM: 128 GB
128137
SSD: 1.92 TB Data center Gen4 NVMe
129138

130139
#### Track performance results
140+
131141
APM metrics are reported to [kibana-stats](https://kibana-stats.elastic.dev/) cluster.
132142
You can filter transactions using labels, e.g. `labels.journeyName : "GET /internal/security/session"`
133143

‎docs/reference/advanced-settings.md‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ mapped_pages:
55

66
# Advanced settings [advanced-options]
77

8-
**Advanced Settings** control the behavior of {{kib}}. You can change the settings that apply to spaces, or to all of {{kib}}. For example, you can change the format used to display dates, specify the default data view, and apply your own branding.
8+
**Advanced Settings** control the behavior of {{kib}}. You can change the settings that apply to a specific space only, or to all of {{kib}}. For example, you can change the format used to display dates, specify the default data view, and apply your own branding.
99

1010
::::{warning}
1111
Changing a setting can affect {{kib}} performance and cause problems that are difficult to diagnose. Setting a property value to a blank field reverts to the default behavior, which might not be compatible with other configuration settings. Deleting a custom setting permanently removes it from {{kib}}.
@@ -27,9 +27,9 @@ To add the privilege, go to the **Roles** management page using the navigation m
2727
For more information on granting access to {{kib}}, refer to [Granting access to {{kib}}](docs-content://deploy-manage/users-roles/cluster-or-deployment-auth/built-in-roles.md).
2828

2929

30-
## Change the space settings [kibana-settings-reference]
30+
## Change the space-specific setting [kibana-settings-reference]
3131

32-
Change the settings that apply only to {{kib}} spaces.
32+
Change the settings that apply only to a speific {{kib}} space.
3333

3434
1. Go to the **Advanced settings** page using the navigation menu or the [global search field](docs-content://get-started/the-stack.md#kibana-navigation-search).
3535
2. Click **Space Settings**.
@@ -498,7 +498,7 @@ $$$visualization-visualize-heatmapChartslibrary$$$`visualization:visualize:legac
498498

499499
## Change the global settings [kibana-global-settings-reference]
500500

501-
Change the settings that apply only to {{kib}} spaces.
501+
Change the only settings that apply to all of {{kib}}.
502502

503503
1. Go to the **Advanced settings** page using the navigation menu or the [global search field](docs-content://get-started/the-stack.md#kibana-navigation-search).
504504
2. Click **Global Settings**.

0 commit comments

Comments
 (0)