rename test and use 'every' in lieu of 'some' when determining if the filter logic should execute

dhurley14 · dhurley14 · commit 2eebbdadb1ce · 2020-07-22T10:40:06.000-04:00
diff --git a/x-pack/plugins/security_solution/server/lib/detection_engine/signals/filter_events_with_list.test.ts b/x-pack/plugins/security_solution/server/lib/detection_engine/signals/filter_events_with_list.test.ts
@@ -193,7 +193,7 @@ describe('filterEventsAgainstList', () => {
       expect(['1.1.1.1', '3.3.3.3', '5.5.5.5', '7.7.7.7', '8.8.8.8', '9.9.9.9']).toEqual(ipVals);
     });
 
-    it('should respond with less items in the list given one exception item with two entries of type list if some values match', async () => {
+    it('should respond with less items in the list given two exception items, each with one entry of type list if some values match', async () => {
       const exceptionItem = getExceptionListItemSchemaMock();
       exceptionItem.entries = [
         {
diff --git a/x-pack/plugins/security_solution/server/lib/detection_engine/signals/filter_events_with_list.ts b/x-pack/plugins/security_solution/server/lib/detection_engine/signals/filter_events_with_list.ts
@@ -103,7 +103,7 @@ export const filterEventsAgainstList = async ({
     }
 
     const valueListExceptionItems = exceptionsList.filter((listItem: ExceptionListItemSchema) => {
-      return listItem.entries.some((entry) => entriesList.is(entry));
+      return listItem.entries.every((entry) => entriesList.is(entry));
     });
 
     // now that we have all the exception items which are value lists (whether single entry or have multiple entries)

Original file line number	Diff line number	Diff line change
`@@ -193,7 +193,7 @@ describe('filterEventsAgainstList', () => {`
`193`	`193`	`expect(['1.1.1.1', '3.3.3.3', '5.5.5.5', '7.7.7.7', '8.8.8.8', '9.9.9.9']).toEqual(ipVals);`
`194`	`194`	`});`
`195`	`195`
`196`		`- it('should respond with less items in the list given one exception item with two entries of type list if some values match', async () => {`
	`196`	`+ it('should respond with less items in the list given two exception items, each with one entry of type list if some values match', async () => {`
`197`	`197`	`const exceptionItem = getExceptionListItemSchemaMock();`
`198`	`198`	`exceptionItem.entries = [`
`199`	`199`	`{`
Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ export const filterEventsAgainstList = async ({`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`const valueListExceptionItems = exceptionsList.filter((listItem: ExceptionListItemSchema) => {`
`106`		`- return listItem.entries.some((entry) => entriesList.is(entry));`
	`106`	`+ return listItem.entries.every((entry) => entriesList.is(entry));`
`107`	`107`	`});`
`108`	`108`
`109`	`109`	`// now that we have all the exception items which are value lists (whether single entry or have multiple entries)`