👌 Apply feedback suggestions

dej611 · dej611 · commit 2d42ea9e1c2b · 2020-11-09T17:04:18.000+01:00
diff --git a/x-pack/plugins/lens/public/pie_visualization/toolbar.tsx b/x-pack/plugins/lens/public/pie_visualization/toolbar.tsx
@@ -125,7 +125,7 @@ export function PieToolbar(props: VisualizationToolbarProps<PieVisualizationStat
         title={i18n.translate('xpack.lens.pieChart.valuesLabel', {
           defaultMessage: 'Labels',
         })}
-        type="values"
+        type="labels"
         groupPosition="left"
         buttonDataTestSubj="lnsLabelsButton"
       >
diff --git a/x-pack/plugins/lens/public/shared_components/toolbar_popover.tsx b/x-pack/plugins/lens/public/shared_components/toolbar_popover.tsx
@@ -11,8 +11,8 @@ import { EuiIconLegend } from '../assets/legend';
 
 const typeToIconMap: { [type: string]: string | IconType } = {
   legend: EuiIconLegend as IconType,
-  values: 'visText',
-  numeric: 'number',
+  labels: 'visText',
+  values: 'number',
 };
 
 export interface ToolbarPopoverProps {
diff --git a/x-pack/plugins/lens/public/xy_visualization/xy_config_panel.tsx b/x-pack/plugins/lens/public/xy_visualization/xy_config_panel.tsx
@@ -262,7 +262,7 @@ export function XyToolbar(props: VisualizationToolbarProps<State>) {
               title={i18n.translate('xpack.lens.xyChart.valuesLabel', {
                 defaultMessage: 'Values',
               })}
-              type="numeric"
+              type="values"
               groupPosition="left"
               buttonDataTestSubj="lnsValuesButton"
               isDisabled={!isValueLabelsEnabled && !isFittingEnabled}

Original file line number	Diff line number	Diff line change
`@@ -125,7 +125,7 @@ export function PieToolbar(props: VisualizationToolbarProps<PieVisualizationStat`
`125`	`125`	`title={i18n.translate('xpack.lens.pieChart.valuesLabel', {`
`126`	`126`	`defaultMessage: 'Labels',`
`127`	`127`	`})}`
`128`		`- type="values"`
	`128`	`+ type="labels"`
`129`	`129`	`groupPosition="left"`
`130`	`130`	`buttonDataTestSubj="lnsLabelsButton"`
`131`	`131`	`>`