use suggestion to remove clearFix empty div

tsullivan · tsullivan · commit 2acd0347bb98 · 2023-08-08T12:41:53.000-07:00
diff --git a/packages/core/chrome/core-chrome-browser-internal/src/ui/project/app_menu.tsx b/packages/core/chrome/core-chrome-browser-internal/src/ui/project/app_menu.tsx
@@ -36,7 +36,6 @@ export const AppMenuBar = ({ isOpen, headerActionMenuMounter }: AppMenuBarProps)
       >
         <HeaderActionMenu mounter={headerActionMenuMounter} />
       </div>
-      <div className="header__actionMenu__clearFix" />
     </EuiThemeProvider>
   );
 };
diff --git a/packages/core/chrome/core-chrome-browser-internal/src/ui/project/header.tsx b/packages/core/chrome/core-chrome-browser-internal/src/ui/project/header.tsx
@@ -189,7 +189,13 @@ export const ProjectHeader = ({
       <SkipToMainContent />
 
       <HeaderTopBanner headerBanner$={observables.headerBanner$} />
-      <header data-test-subj="kibanaProjectHeader">
+      <header
+        data-test-subj="kibanaProjectHeader"
+        css={css`
+          /* FIXME use a variable for the app bar height */
+          margin-bottom: ${headerActionMenuMounter.mount ? 48 : 0}px;
+        `}
+      >
         <div id="globalHeaderBars" data-test-subj="headerGlobalNav" className="header__bars">
           <EuiHeader position="fixed" className="header__firstBar">
             <EuiHeaderSection grow={false}>
diff --git a/src/core/public/styles/chrome/_project.scss b/src/core/public/styles/chrome/_project.scss
@@ -8,9 +8,4 @@
     /* use a high z-index since this component is part of the header */
     z-index: $euiZHeader;
   }
-
-  .header__actionMenu__clearFix {
-    /* make other elements to flow around the fixed menu bar rather than behind it */
-    margin-top: $euiHeaderHeightCompensation;
-  }
 }

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,6 @@ export const AppMenuBar = ({ isOpen, headerActionMenuMounter }: AppMenuBarProps)`
`36`	`36`	`>`
`37`	`37`	`<HeaderActionMenu mounter={headerActionMenuMounter} />`
`38`	`38`	`</div>`
`39`		`- <div className="header__actionMenu__clearFix" />`
`40`	`39`	`</EuiThemeProvider>`
`41`	`40`	`);`
`42`	`41`	`};`
Original file line number	Diff line number	Diff line change
`@@ -8,9 +8,4 @@`
`8`	`8`	`/* use a high z-index since this component is part of the header */`
`9`	`9`	`z-index: $euiZHeader;`
`10`	`10`	`}`
`11`		`-`
`12`		`- .header__actionMenu__clearFix {`
`13`		`- /* make other elements to flow around the fixed menu bar rather than behind it */`
`14`		`- margin-top: $euiHeaderHeightCompensation;`
`15`		`- }`
`16`	`11`	`}`