Skip to content

Commit 2a913e4

Browse files
Skips flake tests and tests with what looks like bugs (#89777)
## Summary Skips tests that have flake or in-determinism. * The sourcer code/tests are being rewritten and then those will come back by other team members. * The timeline open dialog looks to have some click and indeterminism bugs that are being investigated. Skipping for now.
1 parent 3720006 commit 2a913e4

3 files changed

Lines changed: 10 additions & 4 deletions

File tree

x-pack/plugins/security_solution/cypress/integration/data_sources/sourcerer.spec.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,9 @@ import { populateTimeline } from '../../tasks/timeline';
2828
import { SERVER_SIDE_EVENT_COUNT } from '../../screens/timeline';
2929
import { cleanKibana } from '../../tasks/common';
3030

31-
describe('Sourcerer', () => {
31+
// Skipped at the moment as this has flake due to click handler issues. This has been raised with team members
32+
// and the code is being re-worked and then these tests will be unskipped
33+
describe.skip('Sourcerer', () => {
3234
before(() => {
3335
cleanKibana();
3436
});

x-pack/plugins/security_solution/cypress/integration/timelines/creation.spec.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@ import { openTimeline } from '../../tasks/timelines';
4747

4848
import { OVERVIEW_URL } from '../../urls/navigation';
4949

50-
describe('Timelines', () => {
50+
// Skipped at the moment as there looks to be in-deterministic bugs with the open timeline dialog.
51+
describe.skip('Timelines', () => {
5152
beforeEach(() => {
5253
cleanKibana();
5354
});
@@ -89,7 +90,7 @@ describe('Timelines', () => {
8990

9091
cy.get(FAVORITE_TIMELINE).should('exist');
9192
cy.get(TIMELINE_TITLE).should('have.text', timeline.title);
92-
cy.get(TIMELINE_DESCRIPTION).should('have.text', timeline.description);
93+
cy.get(TIMELINE_DESCRIPTION).should('have.text', timeline.description); // This is the flake part where it sometimes does not show/load the timelines correctly
9394
cy.get(TIMELINE_QUERY).should('have.text', `${timeline.query} `);
9495
cy.get(TIMELINE_FILTER(timeline.filter)).should('exist');
9596
cy.get(PIN_EVENT)

x-pack/plugins/security_solution/cypress/tasks/timelines.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,10 @@ export const exportTimeline = (timelineId: string) => {
1919
};
2020

2121
export const openTimeline = (id: string) => {
22-
cy.get(TIMELINE(id), { timeout: 500 }).click();
22+
// This temporary wait here is to reduce flakeyness until we integrate cypress-pipe. Then please let us use cypress pipe.
23+
// Ref: https://www.cypress.io/blog/2019/01/22/when-can-the-test-click/
24+
// Ref: https://github.com/NicholasBoll/cypress-pipe#readme
25+
cy.get(TIMELINE(id)).should('be.visible').wait(1500).click();
2326
};
2427

2528
export const waitForTimelinesPanelToBeLoaded = () => {

0 commit comments

Comments
 (0)