Skips flake tests and tests with what looks like bugs (#89777)

FrankHassanabad · web-flow · commit 2a913e4eb192 · 2021-01-29T15:53:29.000-07:00
## Summary

Skips tests that have flake or in-determinism.
* The sourcer code/tests are being rewritten and then those will come back by other team members.
* The timeline open dialog looks to have some click and indeterminism bugs that are being investigated. Skipping for now.
diff --git a/x-pack/plugins/security_solution/cypress/integration/data_sources/sourcerer.spec.ts b/x-pack/plugins/security_solution/cypress/integration/data_sources/sourcerer.spec.ts
@@ -28,7 +28,9 @@ import { populateTimeline } from '../../tasks/timeline';
 import { SERVER_SIDE_EVENT_COUNT } from '../../screens/timeline';
 import { cleanKibana } from '../../tasks/common';
 
-describe('Sourcerer', () => {
+// Skipped at the moment as this has flake due to click handler issues. This has been raised with team members
+// and the code is being re-worked and then these tests will be unskipped
+describe.skip('Sourcerer', () => {
   before(() => {
     cleanKibana();
   });
diff --git a/x-pack/plugins/security_solution/cypress/integration/timelines/creation.spec.ts b/x-pack/plugins/security_solution/cypress/integration/timelines/creation.spec.ts
@@ -47,7 +47,8 @@ import { openTimeline } from '../../tasks/timelines';
 
 import { OVERVIEW_URL } from '../../urls/navigation';
 
-describe('Timelines', () => {
+// Skipped at the moment as there looks to be in-deterministic bugs with the open timeline dialog.
+describe.skip('Timelines', () => {
   beforeEach(() => {
     cleanKibana();
   });
@@ -89,7 +90,7 @@ describe('Timelines', () => {
 
       cy.get(FAVORITE_TIMELINE).should('exist');
       cy.get(TIMELINE_TITLE).should('have.text', timeline.title);
-      cy.get(TIMELINE_DESCRIPTION).should('have.text', timeline.description);
+      cy.get(TIMELINE_DESCRIPTION).should('have.text', timeline.description); // This is the flake part where it sometimes does not show/load the timelines correctly
       cy.get(TIMELINE_QUERY).should('have.text', `${timeline.query} `);
       cy.get(TIMELINE_FILTER(timeline.filter)).should('exist');
       cy.get(PIN_EVENT)
diff --git a/x-pack/plugins/security_solution/cypress/tasks/timelines.ts b/x-pack/plugins/security_solution/cypress/tasks/timelines.ts
@@ -19,7 +19,10 @@ export const exportTimeline = (timelineId: string) => {
 };
 
 export const openTimeline = (id: string) => {
-  cy.get(TIMELINE(id), { timeout: 500 }).click();
+  // This temporary wait here is to reduce flakeyness until we integrate cypress-pipe. Then please let us use cypress pipe.
+  // Ref: https://www.cypress.io/blog/2019/01/22/when-can-the-test-click/
+  // Ref: https://github.com/NicholasBoll/cypress-pipe#readme
+  cy.get(TIMELINE(id)).should('be.visible').wait(1500).click();
 };
 
 export const waitForTimelinesPanelToBeLoaded = () => {
