Change filter for rule monitoring gaps (#209983)

nkhristinin · elasticmachine · nkhristinin · commit 28f7fec5ac04 · 2025-02-11T19:50:03.000+01:00
## Change filter for rule monitoring gaps Keep only 1 button, and make selection more clear https://github.com/user-attachments/assets/f720ce03-fc38-42ef-87aa-99e22accc646 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 0007203)
diff --git a/x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_gaps/components/rules_with_gaps_overview_panel/index.tsx b/x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_gaps/components/rules_with_gaps_overview_panel/index.tsx
@@ -64,9 +64,9 @@ export const RulesWithGapsOverviewPanel = () => {
     </EuiButton>
   );
 
-  const handleShowRulesWithGapsFilterButtonClick = (value: boolean) => {
+  const handleShowRulesWithGapsFilterButtonClick = () => {
     setFilterOptions({
-      showRulesWithGaps: value,
+      showRulesWithGaps: !showRulesWithGaps,
     });
   };
 
@@ -119,16 +119,10 @@ export const RulesWithGapsOverviewPanel = () => {
         </EuiFlexItem>
         <EuiFlexItem grow={false}>
           <EuiFilterGroup>
-            <EuiFilterButton
-              withNext
-              hasActiveFilters={!showRulesWithGaps}
-              onClick={() => handleShowRulesWithGapsFilterButtonClick(false)}
-            >
-              {i18n.RULE_GAPS_OVERVIEW_PANEL_SHOW_ALL_RULES_LABEL}
-            </EuiFilterButton>
             <EuiFilterButton
               hasActiveFilters={showRulesWithGaps}
-              onClick={() => handleShowRulesWithGapsFilterButtonClick(true)}
+              onClick={handleShowRulesWithGapsFilterButtonClick}
+              iconType={showRulesWithGaps ? `checkInCircleFilled` : undefined}
             >
               {i18n.RULE_GAPS_OVERVIEW_PANEL_SHOW_RULES_WITH_GAPS_LABEL}
             </EuiFilterButton>
diff --git a/x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_gaps/components/rules_with_gaps_overview_panel/translations.tsx b/x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_gaps/components/rules_with_gaps_overview_panel/translations.tsx
@@ -13,18 +13,10 @@ export const RULE_GAPS_OVERVIEW_PANEL_LABEL = i18n.translate(
     defaultMessage: 'Total rules with gaps:',
   }
 );
-
-export const RULE_GAPS_OVERVIEW_PANEL_SHOW_ALL_RULES_LABEL = i18n.translate(
-  'xpack.securitySolution.ruleGapsOverviewPanel.showAllRulesLabel',
-  {
-    defaultMessage: 'Show all rules',
-  }
-);
-
 export const RULE_GAPS_OVERVIEW_PANEL_SHOW_RULES_WITH_GAPS_LABEL = i18n.translate(
   'xpack.securitySolution.ruleGapsOverviewPanel.showRulesWithGapsLabel',
   {
-    defaultMessage: 'Show rules with gaps',
+    defaultMessage: 'Only rules with gaps',
   }
 );
 

Original file line number	Diff line number	Diff line change
`@@ -13,18 +13,10 @@ export const RULE_GAPS_OVERVIEW_PANEL_LABEL = i18n.translate(`
`13`	`13`	`defaultMessage: 'Total rules with gaps:',`
`14`	`14`	`}`
`15`	`15`	`);`
`16`		`-`
`17`		`-export const RULE_GAPS_OVERVIEW_PANEL_SHOW_ALL_RULES_LABEL = i18n.translate(`
`18`		`- 'xpack.securitySolution.ruleGapsOverviewPanel.showAllRulesLabel',`
`19`		`- {`
`20`		`- defaultMessage: 'Show all rules',`
`21`		`- }`
`22`		`-);`
`23`		`-`
`24`	`16`	`export const RULE_GAPS_OVERVIEW_PANEL_SHOW_RULES_WITH_GAPS_LABEL = i18n.translate(`
`25`	`17`	`'xpack.securitySolution.ruleGapsOverviewPanel.showRulesWithGapsLabel',`
`26`	`18`	`{`
`27`		`- defaultMessage: 'Show rules with gaps',`
	`19`	`+ defaultMessage: 'Only rules with gaps',`
`28`	`20`	`}`
`29`	`21`	`);`
`30`	`22`