Remove default from byte formatting component

rylnd · rylnd · commit 215f59ca8b4a · 2020-01-06T16:32:55.000-08:00
If the user has deleted this default, they presumably meant to do so and
we shouldn't supersede it.
diff --git a/x-pack/legacy/plugins/siem/public/components/formatted_bytes/index.test.tsx b/x-pack/legacy/plugins/siem/public/components/formatted_bytes/index.test.tsx
@@ -25,11 +25,11 @@ describe('PreferenceFormattedBytes', () => {
     expect(toJson(wrapper)).toMatchSnapshot();
   });
 
-  test('it renders bytes to hardcoded format when no configuration exists', () => {
+  test('it renders bytes to Numeral formatting when no format setting exists', () => {
     mockUseUiSetting$.mockImplementation(() => [null]);
     const wrapper = mount(<PreferenceFormattedBytesComponent value={bytes} />);
 
-    expect(wrapper.text()).toEqual('2.7MB');
+    expect(wrapper.text()).toEqual('2,806,422');
   });
 
   test('it renders bytes according to the default format', () => {
diff --git a/x-pack/legacy/plugins/siem/public/components/formatted_bytes/index.tsx b/x-pack/legacy/plugins/siem/public/components/formatted_bytes/index.tsx
@@ -12,7 +12,7 @@ import { useUiSetting$ } from '../../lib/kibana';
 
 export const PreferenceFormattedBytesComponent = ({ value }: { value: string | number }) => {
   const [bytesFormat] = useUiSetting$<string>(DEFAULT_BYTES_FORMAT);
-  return <>{numeral(value).format(bytesFormat || '0,0.[0]b')}</>;
+  return <>{numeral(value).format(bytesFormat)}</>;
 };
 
 PreferenceFormattedBytesComponent.displayName = 'PreferenceFormattedBytesComponent';
