Refactor useOpenInDiscoverSectionAction

iblancof · iblancof · commit 1dd08d85bc7f · 2026-02-02T17:04:19.000+01:00
diff --git a/src/platform/plugins/shared/unified_doc_viewer/public/hooks/use_open_in_discover_section_action/index.ts b/src/platform/plugins/shared/unified_doc_viewer/public/hooks/use_open_in_discover_section_action/index.ts
@@ -44,14 +44,17 @@ export function useOpenInDiscoverSectionAction(
       return undefined;
     }
 
-    // TODO: unify repeated return
+    const actionBase = {
+      dataTestSubj,
+      label: OPEN_IN_DISCOVER_LABEL,
+      icon: 'discoverApp',
+      ariaLabel: OPEN_IN_DISCOVER_ARIA_LABEL,
+    };
+
     if (href) {
       return {
-        dataTestSubj,
-        label: OPEN_IN_DISCOVER_LABEL,
+        ...actionBase,
         href,
-        icon: 'discoverApp',
-        ariaLabel: OPEN_IN_DISCOVER_ARIA_LABEL,
         onClick: canOpenInNewTab ? onClick : undefined,
       };
     }
@@ -61,10 +64,7 @@ export function useOpenInDiscoverSectionAction(
     }
 
     return {
-      dataTestSubj,
-      label: OPEN_IN_DISCOVER_LABEL,
-      icon: 'discoverApp',
-      ariaLabel: OPEN_IN_DISCOVER_ARIA_LABEL,
+      ...actionBase,
       onClick,
     };
   }, [canOpenInNewTab, dataTestSubj, href, onClick]);
