feat: 🎸 add translation, improve types

streamich · streamich · commit 1d16a7852e60 · 2020-12-14T11:02:54.000+01:00
diff --git a/x-pack/plugins/lens/public/datatable_visualization/expression.tsx b/x-pack/plugins/lens/public/datatable_visualization/expression.tsx
@@ -264,7 +264,9 @@ export function DatatableComponent(props: DatatableRenderProps) {
     return <EmptyPlaceholder icon={LensIconChartDatatable} />;
   }
 
-  const tableColumns: Array<EuiBasicTableColumn<unknown>> = props.args.columns.columnIds
+  const tableColumns: Array<
+    EuiBasicTableColumn<{ rowIndex: number; [key: string]: unknown }>
+  > = props.args.columns.columnIds
     .map((field) => {
       const col = firstTable.columns.find((c) => c.id === field);
       const filterable = bucketColumns.includes(field);
@@ -346,7 +348,9 @@ export function DatatableComponent(props: DatatableRenderProps) {
     const hasAtLeastOneRowClickAction = props.rowHasRowClickTriggerActions.find((x) => x);
     if (hasAtLeastOneRowClickAction) {
       const actions: EuiTableActionsColumnType<{ rowIndex: number; [key: string]: unknown }> = {
-        name: 'Actions',
+        name: i18n.translate('xpack.lens.datatable.actionsColumnName', {
+          defaultMessage: 'Actions',
+        }),
         actions: [
           {
             name: i18n.translate('xpack.lens.tableRowMore', {
@@ -374,7 +378,7 @@ export function DatatableComponent(props: DatatableRenderProps) {
           },
         ],
       };
-      tableColumns.push(actions as EuiTableActionsColumnType<unknown>);
+      tableColumns.push(actions);
     }
   }
 
