Skip to content

Commit 1b7b0fb

Browse files
author
Aaron Caldwell
committed
Merge remote-tracking branch 'upstream/master' into geojson-file-chunking
2 parents 790abe7 + c87b761 commit 1b7b0fb

613 files changed

Lines changed: 58830 additions & 14400 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@
4646
# Platform
4747
/src/core/ @elastic/kibana-platform
4848
/src/legacy/server/saved_objects/ @elastic/kibana-platform
49-
/src/legacy/ui/public/saved_objects @elastic/kibana-platform
5049
/config/kibana.yml @elastic/kibana-platform
5150
/x-pack/plugins/features/ @elastic/kibana-platform
5251

@@ -56,6 +55,7 @@
5655
/x-pack/legacy/plugins/encrypted_saved_objects/ @elastic/kibana-security
5756
/src/legacy/server/csp/ @elastic/kibana-security
5857
/x-pack/plugins/security/ @elastic/kibana-security
58+
/x-pack/test/api_integration/apis/security/ @elastic/kibana-security
5959

6060
# Kibana Stack Services
6161
/packages/kbn-analytics/ @elastic/kibana-stack-services

.sass-lint.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ files:
77
- 'x-pack/legacy/plugins/rollup/**/*.s+(a|c)ss'
88
- 'x-pack/legacy/plugins/security/**/*.s+(a|c)ss'
99
- 'x-pack/legacy/plugins/canvas/**/*.s+(a|c)ss'
10+
ignore:
11+
- 'x-pack/legacy/plugins/canvas/shareable_runtime/**/*.s+(a|c)ss'
1012
- 'x-pack/legacy/plugins/lens/**/*.s+(a|c)ss'
1113
- 'x-pack/legacy/plugins/maps/**/*.s+(a|c)ss'
1214
rules:

CONTRIBUTING.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -306,6 +306,8 @@ IntelliJ | Settings » Languages & Frameworks » JavaScript » Code Quality To
306306

307307
Another tool we use for enforcing consistent coding style is EditorConfig, which can be set up by installing a plugin in your editor that dynamically updates its configuration. Take a look at the [EditorConfig](http://editorconfig.org/#download) site to find a plugin for your editor, and browse our [`.editorconfig`](https://github.com/elastic/kibana/blob/master/.editorconfig) file to see what config rules we set up.
308308

309+
#### Setup Guide for VS Code Users
310+
309311
Note that for VSCode, to enable "live" linting of TypeScript (and other) file types, you will need to modify your local settings, as shown below. The default for the ESLint extension is to only lint JavaScript file types.
310312

311313
```json
@@ -317,6 +319,14 @@ Note that for VSCode, to enable "live" linting of TypeScript (and other) file ty
317319
]
318320
```
319321

322+
`eslint` can automatically fix trivial lint errors when you save a file by adding this line in your setting.
323+
324+
```json
325+
"eslint.autoFixOnSave": true,
326+
```
327+
328+
It is **not** recommended to use `prettier` plugin on Kibana project. Because settings are in `eslintrc.js` file and it is applied to too many files that shouldn't be prettier-ized.
329+
320330
### Internationalization
321331

322332
All user-facing labels and info texts in Kibana should be internationalized. Please take a look at the [readme](packages/kbn-i18n/README.md) and the [guideline](packages/kbn-i18n/GUIDELINE.md) of the i18n package on how to do so.
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
<!-- Do not edit this file. It is automatically generated by API Documenter. -->
2+
3+
[Home](./index.md) &gt; [kibana-plugin-public](./kibana-plugin-public.md) &gt; [HttpFetchError](./kibana-plugin-public.httpfetcherror.md) &gt; [(constructor)](./kibana-plugin-public.httpfetcherror._constructor_.md)
4+
5+
## HttpFetchError.(constructor)
6+
7+
Constructs a new instance of the `HttpFetchError` class
8+
9+
<b>Signature:</b>
10+
11+
```typescript
12+
constructor(message: string, request: Request, response?: Response | undefined, body?: any);
13+
```
14+
15+
## Parameters
16+
17+
| Parameter | Type | Description |
18+
| --- | --- | --- |
19+
| message | <code>string</code> | |
20+
| request | <code>Request</code> | |
21+
| response | <code>Response &#124; undefined</code> | |
22+
| body | <code>any</code> | |
23+
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<!-- Do not edit this file. It is automatically generated by API Documenter. -->
2+
3+
[Home](./index.md) &gt; [kibana-plugin-public](./kibana-plugin-public.md) &gt; [HttpFetchError](./kibana-plugin-public.httpfetcherror.md) &gt; [body](./kibana-plugin-public.httpfetcherror.body.md)
4+
5+
## HttpFetchError.body property
6+
7+
<b>Signature:</b>
8+
9+
```typescript
10+
readonly body?: any;
11+
```
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
<!-- Do not edit this file. It is automatically generated by API Documenter. -->
2+
3+
[Home](./index.md) &gt; [kibana-plugin-public](./kibana-plugin-public.md) &gt; [HttpFetchError](./kibana-plugin-public.httpfetcherror.md)
4+
5+
## HttpFetchError class
6+
7+
8+
<b>Signature:</b>
9+
10+
```typescript
11+
export declare class HttpFetchError extends Error
12+
```
13+
14+
## Constructors
15+
16+
| Constructor | Modifiers | Description |
17+
| --- | --- | --- |
18+
| [(constructor)(message, request, response, body)](./kibana-plugin-public.httpfetcherror._constructor_.md) | | Constructs a new instance of the <code>HttpFetchError</code> class |
19+
20+
## Properties
21+
22+
| Property | Modifiers | Type | Description |
23+
| --- | --- | --- | --- |
24+
| [body](./kibana-plugin-public.httpfetcherror.body.md) | | <code>any</code> | |
25+
| [request](./kibana-plugin-public.httpfetcherror.request.md) | | <code>Request</code> | |
26+
| [response](./kibana-plugin-public.httpfetcherror.response.md) | | <code>Response &#124; undefined</code> | |
27+
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<!-- Do not edit this file. It is automatically generated by API Documenter. -->
2+
3+
[Home](./index.md) &gt; [kibana-plugin-public](./kibana-plugin-public.md) &gt; [HttpFetchError](./kibana-plugin-public.httpfetcherror.md) &gt; [request](./kibana-plugin-public.httpfetcherror.request.md)
4+
5+
## HttpFetchError.request property
6+
7+
<b>Signature:</b>
8+
9+
```typescript
10+
readonly request: Request;
11+
```
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<!-- Do not edit this file. It is automatically generated by API Documenter. -->
2+
3+
[Home](./index.md) &gt; [kibana-plugin-public](./kibana-plugin-public.md) &gt; [HttpFetchError](./kibana-plugin-public.httpfetcherror.md) &gt; [response](./kibana-plugin-public.httpfetcherror.response.md)
4+
5+
## HttpFetchError.response property
6+
7+
<b>Signature:</b>
8+
9+
```typescript
10+
readonly response?: Response | undefined;
11+
```

docs/development/core/public/kibana-plugin-public.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ The plugin integrates with the core system via lifecycle events: `setup`<!-- -->
1414

1515
| Class | Description |
1616
| --- | --- |
17+
| [HttpFetchError](./kibana-plugin-public.httpfetcherror.md) | |
1718
| [HttpInterceptController](./kibana-plugin-public.httpinterceptcontroller.md) | |
1819
| [SavedObjectsClient](./kibana-plugin-public.savedobjectsclient.md) | Saved Objects is Kibana's data persisentence mechanism allowing plugins to use Elasticsearch for storing plugin state. The client-side SavedObjectsClient is a thin convenience library around the SavedObjects HTTP API for interacting with Saved Objects. |
1920
| [SimpleSavedObject](./kibana-plugin-public.simplesavedobject.md) | This class is a very simple wrapper for SavedObjects loaded from the server with the [SavedObjectsClient](./kibana-plugin-public.savedobjectsclient.md)<!-- -->.<!-- -->It provides basic functionality for creating/saving/deleting saved objects, but doesn't include any type-specific implementations. |

docs/management/dashboard_only_mode/index.asciidoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
[[xpack-dashboard-only-mode]]
33
== Dashboard-only mode
44

5-
deprecated[7.4.0, Using the `kibana_dashboard_only_user` role is deprecated. Use <<kibana-feature-privileges,feature privileges>> instead.]
5+
deprecated[7.4.0, "Using the `kibana_dashboard_only_user` role is deprecated. Use <<kibana-feature-privileges,feature privileges>> instead."]
66

77
In dashboard-only mode, users have access to only the *Dashboard* app.
88
Users can view and filter the dashboards, but cannot create, edit, or delete

0 commit comments

Comments
 (0)