fix PR comment

alexwizp · alexwizp · commit 177415ee08ac · 2020-09-28T15:33:36.000+03:00
diff --git a/src/plugins/vis_type_vega/kibana.json b/src/plugins/vis_type_vega/kibana.json
@@ -3,6 +3,7 @@
   "version": "kibana",
   "server": true,
   "ui": true,
-  "requiredPlugins": ["data", "visualizations", "mapsLegacy", "expressions", "inspector", "usageCollection"],
+  "requiredPlugins": ["data", "visualizations", "mapsLegacy", "expressions", "inspector"],
+  "optionalPlugins": ["usageCollection"],
   "requiredBundles": ["kibanaUtils", "kibanaReact", "visDefaultEditor"]
 }
diff --git a/src/plugins/vis_type_vega/server/usage_collector/index.ts b/src/plugins/vis_type_vega/server/usage_collector/index.ts
@@ -24,7 +24,7 @@ import { ConfigObservable } from '../types';
 export function registerVegaUsageCollector(
   collectorSet: UsageCollectionSetup,
   config: ConfigObservable
-): void {
+) {
   const collector = collectorSet.makeUsageCollector(getUsageCollector(config));
 
   collectorSet.registerCollector(collector);
diff --git a/src/plugins/visualizations/kibana.json b/src/plugins/visualizations/kibana.json
@@ -3,6 +3,7 @@
   "version": "kibana",
   "server": true,
   "ui": true,
-  "requiredPlugins": ["data", "expressions", "uiActions", "embeddable", "usageCollection", "inspector", "dashboard"],
+  "requiredPlugins": ["data", "expressions", "uiActions", "embeddable", "inspector", "dashboard"],
+  "optionalPlugins": ["usageCollection"],
   "requiredBundles": ["kibanaUtils", "discover", "savedObjects"]
 }
diff --git a/src/plugins/visualizations/server/usage_collector/index.ts b/src/plugins/visualizations/server/usage_collector/index.ts
@@ -25,7 +25,7 @@ import { getUsageCollector } from './get_usage_collector';
 export function registerVisualizationsCollector(
   collectorSet: UsageCollectionSetup,
   config: Observable<{ kibana: { index: string } }>
-): void {
+) {
   const collector = collectorSet.makeUsageCollector(getUsageCollector(config));
   collectorSet.registerCollector(collector);
 }

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@`
`3`	`3`	`"version": "kibana",`
`4`	`4`	`"server": true,`
`5`	`5`	`"ui": true,`
`6`		`- "requiredPlugins": ["data", "visualizations", "mapsLegacy", "expressions", "inspector", "usageCollection"],`
	`6`	`+ "requiredPlugins": ["data", "visualizations", "mapsLegacy", "expressions", "inspector"],`
	`7`	`+ "optionalPlugins": ["usageCollection"],`
`7`	`8`	`"requiredBundles": ["kibanaUtils", "kibanaReact", "visDefaultEditor"]`
`8`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ import { getUsageCollector } from './get_usage_collector';`
`25`	`25`	`export function registerVisualizationsCollector(`
`26`	`26`	`collectorSet: UsageCollectionSetup,`
`27`	`27`	`config: Observable<{ kibana: { index: string } }>`
`28`		`-): void {`
	`28`	`+) {`
`29`	`29`	`const collector = collectorSet.makeUsageCollector(getUsageCollector(config));`
`30`	`30`	`collectorSet.registerCollector(collector);`
`31`	`31`	`}`