[Guided onboarding] Hide the button when the user quits a guide

yuliacech · yuliacech · commit 112e1321e08f · 2022-11-14T19:36:34.000+01:00
diff --git a/src/plugins/guided_onboarding/public/components/guide_button.tsx b/src/plugins/guided_onboarding/public/components/guide_button.tsx
@@ -51,14 +51,16 @@ export const GuideButton = ({
 
   // if there is no active guide
   if (!pluginState || !pluginState.activeGuide || !pluginState.activeGuide.isActive) {
-    // if still active period and the user has not started a guide, quit or skipped the guide,
+    // if still active period and the user has not started a guide or skipped the guide,
     // display the button that redirects to the landing page
     if (
-      pluginState?.isActivePeriod &&
-      (pluginState?.status === 'not_started' ||
-        pluginState?.status === 'quit' ||
-        pluginState?.status === 'skipped')
+      !(
+        pluginState?.isActivePeriod &&
+        (pluginState?.status === 'not_started' || pluginState?.status === 'skipped')
+      )
     ) {
+      return null;
+    } else {
       return (
         <EuiButton
           onClick={navigateToLandingPage}
@@ -73,8 +75,6 @@ export const GuideButton = ({
         </EuiButton>
       );
     }
-
-    return null;
   }
   const stepNumber = getStepNumber(pluginState.activeGuide);
   const stepReadyToComplete = pluginState.activeGuide.steps.find(
diff --git a/src/plugins/guided_onboarding/public/components/guide_panel.test.tsx b/src/plugins/guided_onboarding/public/components/guide_panel.test.tsx
@@ -145,23 +145,23 @@ describe('Guided setup', () => {
           expect(exists('guideButton')).toBe(false);
         });
 
-        test('shows redirect button when a user quit the guide', async () => {
+        test('shows redirect button when a user skipped on the landing page', async () => {
           const { exists } = await setupComponentWithPluginStateMock(httpClient, {
-            status: 'quit',
+            status: 'skipped',
             isActivePeriod: true,
           });
 
           expect(exists('guideButtonRedirect')).toBe(true);
           expect(exists('guideButton')).toBe(false);
         });
 
-        test('shows redirect button when a user skipped on the landing page', async () => {
+        test('hides redirect button when a user quit the guide', async () => {
           const { exists } = await setupComponentWithPluginStateMock(httpClient, {
-            status: 'skipped',
+            status: 'quit',
             isActivePeriod: true,
           });
 
-          expect(exists('guideButtonRedirect')).toBe(true);
+          expect(exists('guideButtonRedirect')).toBe(false);
           expect(exists('guideButton')).toBe(false);
         });
 
