Skip to content

Commit 0cb37b0

Browse files
parkiinoparkiino
committed
modify tests, policy response spacing alts
1 parent 1a75c0a commit 0cb37b0

4 files changed

Lines changed: 26 additions & 35 deletions

File tree

‎x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/details/endpoint_details.tsx‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ export const EndpointDetails = memo(
167167
}),
168168
description: (
169169
<EuiFlexGroup alignItems="center">
170-
<EuiFlexItem>
170+
<EuiFlexItem grow={false}>
171171
<EndpointPolicyLink
172172
policyId={details.Endpoint.policy.applied.id}
173173
data-test-subj="policyDetailsValue"
@@ -212,7 +212,7 @@ export const EndpointDetails = memo(
212212
// @ts-ignore
213213
<EuiBadge
214214
color={POLICY_STATUS_TO_BADGE_COLOR[policyStatus] || 'default'}
215-
data-test-subj="policyStatusHealth"
215+
data-test-subj="policyStatusValue"
216216
href={policyResponseUri}
217217
onClick={policyStatusClickHandler}
218218
>
@@ -278,7 +278,6 @@ export const EndpointDetails = memo(
278278
onClick={handleReassignEndpointsClick}
279279
data-test-subj="endpointDetailsLinkToIngest"
280280
>
281-
<EuiIcon type="savedObjectsApp" className="linkToAppIcon" />
282281
<FormattedMessage
283282
id="xpack.securitySolution.endpoint.details.linkToIngestTitle"
284283
defaultMessage="Reassign Policy"

‎x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/details/index.tsx‎

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import {
2020
import { useHistory } from 'react-router-dom';
2121
import { FormattedMessage } from '@kbn/i18n/react';
2222
import { i18n } from '@kbn/i18n';
23+
import styled from 'styled-components';
2324
import { useToasts } from '../../../../../common/lib/kibana';
2425
import { useEndpointSelector } from '../hooks';
2526
import { urlFromQueryParams } from '../url_from_query_params';
@@ -131,6 +132,14 @@ export const EndpointDetailsFlyout = memo(() => {
131132

132133
EndpointDetailsFlyout.displayName = 'EndpointDetailsFlyout';
133134

135+
const PolicyResponseFlyout = styled.div`
136+
.endpointDetailsPolicyResponseFlyoutBody {
137+
.euiFlyoutBody__overflowContent {
138+
padding-top: 0;
139+
}
140+
}
141+
`;
142+
134143
const PolicyResponseFlyoutPanel = memo<{
135144
hostMeta: HostMetadata;
136145
}>(({ hostMeta }) => {
@@ -171,12 +180,15 @@ const PolicyResponseFlyoutPanel = memo<{
171180
}, [backToDetailsClickHandler, detailsUri]);
172181

173182
return (
174-
<>
183+
<PolicyResponseFlyout>
175184
<FlyoutSubHeader
176185
backButton={backButtonProp}
177186
data-test-subj="endpointDetailsPolicyResponseFlyoutHeader"
178187
/>
179-
<EuiFlyoutBody data-test-subj="endpointDetailsPolicyResponseFlyoutBody">
188+
<EuiFlyoutBody
189+
data-test-subj="endpointDetailsPolicyResponseFlyoutBody"
190+
className="endpointDetailsPolicyResponseFlyoutBody"
191+
>
180192
<EuiText data-test-subj="endpointDetailsPolicyResponseFlyoutTitle">
181193
<h4>
182194
<FormattedMessage
@@ -209,7 +221,7 @@ const PolicyResponseFlyoutPanel = memo<{
209221
/>
210222
)}
211223
</EuiFlyoutBody>
212-
</>
224+
</PolicyResponseFlyout>
213225
);
214226
});
215227

‎x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/details/policy_response.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import {
2929
*/
3030
const PolicyResponseConfigAccordion = styled(EuiAccordion)`
3131
.euiAccordion__triggerWrapper {
32-
padding: ${(props) => props.theme.eui.paddingSizes.s};
32+
padding: ${(props) => props.theme.eui.paddingSizes.xs};
3333
}
3434
3535
&.euiAccordion-isOpen {

‎x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/index.test.tsx‎

Lines changed: 8 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -645,49 +645,29 @@ describe('when on the list page', () => {
645645

646646
it('should display Success overall policy status', async () => {
647647
const renderResult = await renderAndWaitForData();
648-
const policyStatusLink = await renderResult.findByTestId('policyStatusValue');
649-
expect(policyStatusLink.textContent).toEqual('Success');
650-
651-
const policyStatusHealth = await renderResult.findByTestId('policyStatusHealth');
652-
expect(
653-
policyStatusHealth.querySelector('[data-euiicon-type][color="success"]')
654-
).not.toBeNull();
648+
const policyStatusBadge = await renderResult.findByTestId('policyStatusValue');
649+
expect(policyStatusBadge.textContent).toEqual('Success');
655650
});
656651

657652
it('should display Warning overall policy status', async () => {
658653
mockEndpointListApi(createPolicyResponse(HostPolicyResponseActionStatus.warning));
659654
const renderResult = await renderAndWaitForData();
660-
const policyStatusLink = await renderResult.findByTestId('policyStatusValue');
661-
expect(policyStatusLink.textContent).toEqual('Warning');
662-
663-
const policyStatusHealth = await renderResult.findByTestId('policyStatusHealth');
664-
expect(
665-
policyStatusHealth.querySelector('[data-euiicon-type][color="warning"]')
666-
).not.toBeNull();
655+
const policyStatusBadge = await renderResult.findByTestId('policyStatusValue');
656+
expect(policyStatusBadge.textContent).toEqual('Warning');
667657
});
668658

669659
it('should display Failed overall policy status', async () => {
670660
mockEndpointListApi(createPolicyResponse(HostPolicyResponseActionStatus.failure));
671661
const renderResult = await renderAndWaitForData();
672-
const policyStatusLink = await renderResult.findByTestId('policyStatusValue');
673-
expect(policyStatusLink.textContent).toEqual('Failed');
674-
675-
const policyStatusHealth = await renderResult.findByTestId('policyStatusHealth');
676-
expect(
677-
policyStatusHealth.querySelector('[data-euiicon-type][color="danger"]')
678-
).not.toBeNull();
662+
const policyStatusBadge = await renderResult.findByTestId('policyStatusValue');
663+
expect(policyStatusBadge.textContent).toEqual('Failed');
679664
});
680665

681666
it('should display Unknown overall policy status', async () => {
682667
mockEndpointListApi(createPolicyResponse('' as HostPolicyResponseActionStatus));
683668
const renderResult = await renderAndWaitForData();
684-
const policyStatusLink = await renderResult.findByTestId('policyStatusValue');
685-
expect(policyStatusLink.textContent).toEqual('Unknown');
686-
687-
const policyStatusHealth = await renderResult.findByTestId('policyStatusHealth');
688-
expect(
689-
policyStatusHealth.querySelector('[data-euiicon-type][color="subdued"]')
690-
).not.toBeNull();
669+
const policyStatusBadge = await renderResult.findByTestId('policyStatusValue');
670+
expect(policyStatusBadge.textContent).toEqual('Unknown');
691671
});
692672

693673
it('should include the link to reassignment in Ingest', async () => {

0 commit comments

Comments
 (0)