[Fleet] Remove duplication between two files #103282

John Schulz · kibanamachine · commit 08b6fc4c8db9 · 2021-06-24T16:59:35.000Z
## Summary

`public/applications/integrations/constants.tsx` and
`public/applications/integrations/sections/epm/constants.tsx` are identical except for this line in `public/applications/integrations/constants.tsx`

```ts
export * from '../../constants';
```

This PR removes all the duplication from the "upper" file (`public/applications/integrations/constants.tsx`) and leaves the other code "down" in `/sections/epm/` closer to where it's used.

Initially, I deleted `public/applications/integrations/constants.tsx` entirely but several files do `import` the constants it exports, so I left it.
diff --git a/x-pack/plugins/fleet/public/applications/integrations/constants.tsx b/x-pack/plugins/fleet/public/applications/integrations/constants.tsx
@@ -5,57 +5,4 @@
  * 2.0.
  */
 
-import type { IconType } from '@elastic/eui';
-
-import type { ServiceName } from '../../types';
-import { ElasticsearchAssetType, KibanaAssetType } from '../../types';
-
 export * from '../../constants';
-
-// only allow Kibana assets for the kibana key, ES asssets for elasticsearch, etc
-type ServiceNameToAssetTypes = Record<Extract<ServiceName, 'kibana'>, KibanaAssetType[]> &
-  Record<Extract<ServiceName, 'elasticsearch'>, ElasticsearchAssetType[]>;
-
-export const DisplayedAssets: ServiceNameToAssetTypes = {
-  kibana: Object.values(KibanaAssetType),
-  elasticsearch: Object.values(ElasticsearchAssetType),
-};
-export type DisplayedAssetType = KibanaAssetType | ElasticsearchAssetType;
-
-export const AssetTitleMap: Record<DisplayedAssetType, string> = {
-  dashboard: 'Dashboard',
-  ilm_policy: 'ILM Policy',
-  ingest_pipeline: 'Ingest Pipeline',
-  transform: 'Transform',
-  index_pattern: 'Index Pattern',
-  index_template: 'Index Template',
-  component_template: 'Component Template',
-  search: 'Saved Search',
-  visualization: 'Visualization',
-  map: 'Map',
-  data_stream_ilm_policy: 'Data Stream ILM Policy',
-  lens: 'Lens',
-  security_rule: 'Security Rule',
-  ml_module: 'ML Module',
-};
-
-export const ServiceTitleMap: Record<ServiceName, string> = {
-  kibana: 'Kibana',
-  elasticsearch: 'Elasticsearch',
-};
-
-export const AssetIcons: Record<KibanaAssetType, IconType> = {
-  dashboard: 'dashboardApp',
-  index_pattern: 'indexPatternApp',
-  search: 'searchProfilerApp',
-  visualization: 'visualizeApp',
-  map: 'emsApp',
-  lens: 'lensApp',
-  security_rule: 'securityApp',
-  ml_module: 'mlApp',
-};
-
-export const ServiceIcons: Record<ServiceName, IconType> = {
-  elasticsearch: 'logoElasticsearch',
-  kibana: 'logoKibana',
-};
diff --git a/x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/assets/assets_accordion.tsx b/x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/assets/assets_accordion.tsx
@@ -20,7 +20,7 @@ import {
   EuiNotificationBadge,
 } from '@elastic/eui';
 
-import { AssetTitleMap } from '../../../../../constants';
+import { AssetTitleMap } from '../../../constants';
 
 import { getHrefToObjectInKibanaApp, useStartServices } from '../../../../../hooks';
 
