Skip to content

Commit 06c8b42

Browse files
Wylie Conlonkibanamachine
authored andcommitted
[Lens] Split up dimension panel code (#80423)
* [Lens] Split up dimension panel code * Fix test failures * Style updates Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
1 parent 2b91953 commit 06c8b42

11 files changed

Lines changed: 1821 additions & 1632 deletions

File tree

x-pack/plugins/lens/public/indexpattern_datasource/__mocks__/state_helpers.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,5 @@ export const {
1717
sortByField,
1818
hasField,
1919
updateLayerIndexPattern,
20+
mergeLayer,
2021
} = actual;

x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_editor.tsx

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,16 @@ import {
1616
EuiListGroupItemProps,
1717
EuiFormLabel,
1818
} from '@elastic/eui';
19-
import { IndexPatternDimensionEditorProps, OperationSupportMatrix } from './dimension_panel';
19+
import { IndexPatternDimensionEditorProps } from './dimension_panel';
20+
import { OperationSupportMatrix } from './operation_support';
2021
import { IndexPatternColumn, OperationType } from '../indexpattern';
2122
import {
2223
operationDefinitionMap,
2324
getOperationDisplay,
2425
buildColumn,
2526
changeField,
2627
} from '../operations';
27-
import { deleteColumn, changeColumn, updateColumnParam } from '../state_helpers';
28+
import { deleteColumn, changeColumn, updateColumnParam, mergeLayer } from '../state_helpers';
2829
import { FieldSelect } from './field_select';
2930
import { hasField, fieldIsInvalid } from '../utils';
3031
import { BucketNestingEditor } from './bucket_nesting_editor';
@@ -394,12 +395,11 @@ export function DimensionEditor(props: DimensionEditorProps) {
394395
<LabelInput
395396
value={selectedColumn.label}
396397
onChange={(value) => {
397-
setState({
398-
...state,
399-
layers: {
400-
...state.layers,
401-
[layerId]: {
402-
...state.layers[layerId],
398+
setState(
399+
mergeLayer({
400+
state,
401+
layerId,
402+
newLayer: {
403403
columns: {
404404
...state.layers[layerId].columns,
405405
[columnId]: {
@@ -409,8 +409,8 @@ export function DimensionEditor(props: DimensionEditorProps) {
409409
},
410410
},
411411
},
412-
},
413-
});
412+
})
413+
);
414414
}}
415415
/>
416416
)}

0 commit comments

Comments
 (0)