createRootWithCorePlugins support for cliArgs which wasn't backported to 7.x

rudolf · rudolf · commit 04bc5eaddda3 · 2020-12-18T12:19:00.000+01:00
diff --git a/src/core/server/saved_objects/migrationsv2/integration_tests/run.sh b/src/core/server/saved_objects/migrationsv2/integration_tests/run.sh
@@ -0,0 +1,8 @@
+nohup node --max-old-space-size=6000 scripts/kibana.js  --migrations.enableV2=true
+--dev --no-watch --no-optimizer < /dev/null > running.log 2>&1 &
+nohup node --max-old-space-size=6000 scripts/kibana.js  --migrations.enableV2=true
+--dev --no-watch --no-optimizer < /dev/null > running.log 2>&1 &
+nohup node --max-old-space-size=6000 scripts/kibana.js  --migrations.enableV2=true
+--dev --no-watch --no-optimizer < /dev/null > running.log 2>&1 &
+nohup node --max-old-space-size=6000 scripts/kibana.js  --migrations.enableV2=true
+--dev --no-watch --no-optimizer < /dev/null > running.log 2>&1 &
diff --git a/src/core/test_helpers/kbn_server.ts b/src/core/test_helpers/kbn_server.ts
@@ -123,8 +123,11 @@ export function createRoot(settings = {}, cliArgs: Partial<CliArgs> = {}) {
  *  @param {Object} [settings={}] Any config overrides for this instance.
  *  @returns {Root}
  */
-export function createRootWithCorePlugins(settings = {}) {
-  return createRootWithSettings(defaultsDeep({}, settings, DEFAULT_SETTINGS_WITH_CORE_PLUGINS));
+export function createRootWithCorePlugins(settings = {}, cliArgs: Partial<CliArgs> = {}) {
+  return createRootWithSettings(
+    defaultsDeep({}, settings, DEFAULT_SETTINGS_WITH_CORE_PLUGINS),
+    cliArgs
+  );
 }
 
 /**
