[Lens] apply suggestions

dimaanj · dimaanj · commit 049b25009f05 · 2022-09-06T15:02:09.000+03:00
diff --git a/src/plugins/kibana_usage_collection/server/collectors/management/schema.ts b/src/plugins/kibana_usage_collection/server/collectors/management/schema.ts
@@ -498,7 +498,7 @@ export const stackManagementSchema: MakeSchemaFrom<UsageStats> = {
     type: 'boolean',
     _meta: { description: 'Non-default value of setting.' },
   },
-  'unifiedFieldList:useFieldExistenceSampling': {
+  'lens:useFieldExistenceSampling': {
     type: 'boolean',
     _meta: { description: 'Non-default value of setting.' },
   },
diff --git a/src/plugins/kibana_usage_collection/server/collectors/management/types.ts b/src/plugins/kibana_usage_collection/server/collectors/management/types.ts
@@ -135,7 +135,7 @@ export interface UsageStats {
   'discover:rowHeightOption': number;
   hideAnnouncements: boolean;
   isDefaultIndexMigrated: boolean;
-  'unifiedFieldList:useFieldExistenceSampling': boolean;
+  'lens:useFieldExistenceSampling': boolean;
   'metrics:allowCheckingForFailedShards': boolean;
   'observability:apmOperationsTab': boolean;
   'observability:apmProgressiveLoading': string;
diff --git a/src/plugins/telemetry/schema/oss_plugins.json b/src/plugins/telemetry/schema/oss_plugins.json
@@ -8515,7 +8515,7 @@
             "description": "Non-default value of setting."
           }
         },
-        "unifiedFieldList:useFieldExistenceSampling": {
+        "lens:useFieldExistenceSampling": {
           "type": "boolean",
           "_meta": {
             "description": "Non-default value of setting."
diff --git a/src/plugins/unified_field_list/common/index.ts b/src/plugins/unified_field_list/common/index.ts
@@ -7,4 +7,4 @@
  */
 
 export const PLUGIN_ID = 'unifiedFieldList';
-export const FIELD_EXISTENCE_SETTING = 'unifiedFieldList:useFieldExistenceSampling';
+export const FIELD_EXISTENCE_SETTING = 'lens:useFieldExistenceSampling';
diff --git a/test/api_integration/apis/unified_field_list/legacy_existing_fields.ts b/test/api_integration/apis/unified_field_list/legacy_existing_fields.ts
@@ -171,15 +171,15 @@ export default ({ getService }: FtrProviderContext) => {
         'x-pack/test/functional/fixtures/kbn_archiver/visualize/default'
       );
       await kibanaServer.uiSettings.update({
-        'unifiedFieldList:useFieldExistenceSampling': true,
+        'lens:useFieldExistenceSampling': true,
       });
     });
     after(async () => {
       await esArchiver.unload('x-pack/test/functional/es_archives/logstash_functional');
       await esArchiver.unload('x-pack/test/functional/es_archives/visualize/default');
       await kibanaServer.savedObjects.cleanStandardList();
       await kibanaServer.uiSettings.update({
-        'unifiedFieldList:useFieldExistenceSampling': false,
+        'lens:useFieldExistenceSampling': false,
       });
     });
 
diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/datapanel.tsx b/x-pack/plugins/lens/public/indexpattern_datasource/datapanel.tsx
@@ -357,7 +357,7 @@ export const InnerIndexPatternDataPanel = function InnerIndexPatternDataPanel({
       }),
     };
 
-    const isUsingSampling = core.uiSettings.get('unifiedFieldList:useFieldExistenceSampling');
+    const isUsingSampling = core.uiSettings.get('lens:useFieldExistenceSampling');
 
     const fieldGroupDefinitions: FieldGroups = {
       SpecialFields: {
diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/field_item.tsx b/x-pack/plugins/lens/public/indexpattern_datasource/field_item.tsx
@@ -367,9 +367,7 @@ function FieldItemPopoverContents(props: FieldItemProps) {
           }
 
           if (params?.noDataFound) {
-            const isUsingSampling = core.uiSettings.get(
-              'unifiedFieldList:useFieldExistenceSampling'
-            );
+            const isUsingSampling = core.uiSettings.get('lens:useFieldExistenceSampling');
             return (
               <>
                 <EuiText size="s">

Original file line number	Diff line number	Diff line change
`@@ -8515,7 +8515,7 @@`
`8515`	`8515`	`"description": "Non-default value of setting."`
`8516`	`8516`	`}`
`8517`	`8517`	`},`
`8518`		`- "unifiedFieldList:useFieldExistenceSampling": {`
	`8518`	`+ "lens:useFieldExistenceSampling": {`
`8519`	`8519`	`"type": "boolean",`
`8520`	`8520`	`"_meta": {`
`8521`	`8521`	`"description": "Non-default value of setting."`