Add global level data_stream.dataset dashboard filter by milan-elastic · Pull Request #9995 · elastic/integrations

milan-elastic · 2024-05-28T06:59:15Z

Proposed commit message

Add a global filter to the dashboard and remove the subfilters on the dataset and a global filter on the dataset is introduced. Filters on data_stream.dataset are applied with a phrase type filter on the dataset that is being used in that particular dashboard.

Expect the above mentioned changes done in following selected packages to ease the review

prometheus
oracle_weblogic
containerd
azure_application_insights
mysql
springboot
nginx ingress controller
nginx
istio
traefik

Checklist

I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's changelog.yml file.
I have verified that Kibana version constraints are current according to guidelines.

Related issues

Relates Need to add data_stream.dataset filter in dashboards across all the integrations that have it missing. #9323

Screenshot

Prometheus

Before	After

Oracle Weblogic

Deployed application Before	Deployed application After

log overview Before	log overview After

Threadpool Before	Threadpool After

Containerd

Server Before	Server After
Before	After

Azure Application insights

Before	After
App state overview Before	App state overview After

Mysql

Logs overview Before	Logs overview After

Database Before	Database After

SpringBoot

Access Before	Access After

Audit events Before	Audit events After

Memory and Threads Before	Memory and Threads After

Overview Before	Overview After

Nginx ingress controller

Access Before	Access After

Access Before	Access After

Nginx

Log Overview Before	Log Overview After

Access and Error Before	Access and Error After

Metrics Overview Before	Metrics Overview After

Istio

Overview Before	Overview After

Traffic Before	Traffic After

Traefik

Access Overview Before	Access After

elasticmachine · 2024-05-29T08:10:43Z

🚀 Benchmarks report

Package `mysql` 👍(0) 💚(1) 💔(1)

Expand to view

Data stream	Previous EPS	New EPS	Diff (%)	Result
`error`	26315.79	13698.63	-12617.16 (-47.95%)	💔

Package `nginx` 👍(0) 💚(1) 💔(1)

Expand to view

Data stream	Previous EPS	New EPS	Diff (%)	Result
`access`	2710.03	1569.86	-1140.17 (-42.07%)	💔

Package `nginx_ingress_controller` 👍(1) 💚(0) 💔(1)

Expand to view

Data stream	Previous EPS	New EPS	Diff (%)	Result
`error`	34482.76	17857.14	-16625.62 (-48.21%)	💔

Package `oracle_weblogic` 👍(1) 💚(1) 💔(2)

Expand to view

Data stream	Previous EPS	New EPS	Diff (%)	Result
`admin_server`	13513.51	9900.99	-3612.52 (-26.73%)	💔
`domain`	18181.82	12658.23	-5523.59 (-30.38%)	💔

Package `spring_boot` 👍(2) 💚(0) 💔(1)

Expand to view

Data stream	Previous EPS	New EPS	Diff (%)	Result
`http_trace`	13333.33	10101.01	-3232.32 (-24.24%)	💔

To see the full report comment with /test benchmark fullreport

harnish-crest-data

LGTM! 🚀

agithomas · 2024-06-18T05:57:44Z

@milan-elastic ,there are a few panels under istio without data. Can this be verified - if there are no datasets missing? I understand that the data is not present in the "before" scenario. However, in such cases, it is best to double-check. Please confirm

agithomas · 2024-06-18T05:58:52Z

Kindly check if validations.yml entry needs to be removed for some of the datastreams / packages? Example : nginx_ingresscontroller

…-dataset-filters-dashboard-level-set3

milan-elastic · 2024-06-19T09:26:29Z

@milan-elastic ,there are a few panels under istio without data. Can this be verified - if there are no datasets missing? I understand that the data is not present in the "before" scenario. However, in such cases, it is best to double-check. Please confirm

Updated the screenshot and verified the dashboard for istio is working as expected.

milan-elastic · 2024-06-19T09:28:34Z

Kindly check if validations.yml entry needs to be removed for some of the datastreams / packages? Example : nginx_ingresscontroller

I have re-checked all the validations.yml in the packages of this PR and found that azure_application_insights needs to remove the validations.yml file. So I have removed it. Thanks!

agithomas

LGTM!

milan-elastic · 2024-06-24T05:45:25Z

@gizas @constanca-m Can you please review and provide code owner approval for istio, containerd and nginx ingress controller packages?

…-dataset-filters-dashboard-level-set3

elasticmachine · 2024-06-26T07:41:23Z

💚 Build Succeeded

Buildkite Build
Commit: 0140524

History

💚 Build #12659 succeeded c3b09e6
💚 Build #12167 succeeded c2ab6c2
💚 Build #12165 succeeded 4768ec7
💚 Build #12091 succeeded fd50027
💚 Build #12031 succeeded 11d1baa
💚 Build #11972 succeeded 2c70736

cc @milan-elastic

elastic-sonarqube · 2024-06-26T07:41:24Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

elasticmachine · 2024-06-26T09:41:10Z

Package azure_application_insights - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=azure_application_insights

elasticmachine · 2024-06-26T09:41:11Z

Package containerd - 0.4.0 containing this change is available at https://epr.elastic.co/search?package=containerd

elasticmachine · 2024-06-26T09:41:12Z

Package istio - 0.6.0 containing this change is available at https://epr.elastic.co/search?package=istio

elasticmachine · 2024-06-26T09:41:13Z

Package mysql - 1.21.0 containing this change is available at https://epr.elastic.co/search?package=mysql

elasticmachine · 2024-06-26T09:41:14Z

Package nginx - 1.21.0 containing this change is available at https://epr.elastic.co/search?package=nginx

elasticmachine · 2024-06-26T09:41:15Z

Package nginx_ingress_controller - 1.9.0 containing this change is available at https://epr.elastic.co/search?package=nginx_ingress_controller

elasticmachine · 2024-06-26T09:41:15Z

Package oracle_weblogic - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=oracle_weblogic

elasticmachine · 2024-06-26T09:41:16Z

Package prometheus - 1.16.0 containing this change is available at https://epr.elastic.co/search?package=prometheus

elasticmachine · 2024-06-26T09:41:17Z

Package spring_boot - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=spring_boot

elasticmachine · 2024-06-26T09:41:18Z

Package traefik - 2.1.0 containing this change is available at https://epr.elastic.co/search?package=traefik

add dashboard level filter for prometheus

2c70736

milan-elastic self-assigned this May 28, 2024

milan-elastic added 4 commits May 29, 2024 12:36

add dashboard level filter oracle_weblogic

db91557

add dashboard level filter for contairnerd

29754de

add dashboard level dataset filter for azure application insights

7471026

add dashboard level filter for mysql

11d1baa

milan-elastic added 5 commits May 30, 2024 13:10

add dashboard level filter for springboot

7c57f66

add dashboard level filter for nginx_ingress_controller

3e00c33

add dashboard level filter nginx

129a59e

add dashboard level filter for istio

fd50027

add dashboard level filter for traefik

2174dfd

milan-elastic mentioned this pull request May 30, 2024

Need to add data_stream.dataset filter in dashboards across all the integrations that have it missing. #9323

Closed

58 tasks

milan-elastic marked this pull request as ready for review June 3, 2024 04:44

milan-elastic requested review from a team as code owners June 3, 2024 04:44

milan-elastic requested review from constanca-m and gizas June 3, 2024 04:44

update link for changelog.yml

4768ec7

harnish-crest-data self-requested a review June 3, 2024 05:23

remove validation.yml files

c2ab6c2

harnish-crest-data approved these changes Jun 4, 2024

View reviewed changes

Merge branch 'main' of github.com:milan-elastic/integrations into add…

c3b09e6

…-dataset-filters-dashboard-level-set3

agithomas approved these changes Jun 20, 2024

View reviewed changes

constanca-m approved these changes Jun 26, 2024

View reviewed changes

gizas approved these changes Jun 26, 2024

View reviewed changes

Merge branch 'main' of github.com:milan-elastic/integrations into add…

0140524

…-dataset-filters-dashboard-level-set3

milan-elastic merged commit 79e161a into elastic:main Jun 26, 2024

Conversation

milan-elastic commented May 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed commit message

Checklist

Related issues

Screenshot

Uh oh!

elasticmachine commented May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Benchmarks report

Package mysql 👍(0) 💚(1) 💔(1)

Package nginx 👍(0) 💚(1) 💔(1)

Package nginx_ingress_controller 👍(1) 💚(0) 💔(1)

Package oracle_weblogic 👍(1) 💚(1) 💔(2)

Package spring_boot 👍(2) 💚(0) 💔(1)

Uh oh!

harnish-crest-data left a comment

Choose a reason for hiding this comment

Uh oh!

agithomas commented Jun 18, 2024

Uh oh!

agithomas commented Jun 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

milan-elastic commented Jun 19, 2024

Uh oh!

milan-elastic commented Jun 19, 2024

Uh oh!

agithomas left a comment

Choose a reason for hiding this comment

Uh oh!

milan-elastic commented Jun 24, 2024

Uh oh!

elasticmachine commented Jun 26, 2024

💚 Build Succeeded

History

Uh oh!

elastic-sonarqube bot commented Jun 26, 2024

Quality Gate passed

Uh oh!

elasticmachine commented Jun 26, 2024

Uh oh!

elasticmachine commented Jun 26, 2024

Uh oh!

elasticmachine commented Jun 26, 2024

Uh oh!

elasticmachine commented Jun 26, 2024

Uh oh!

elasticmachine commented Jun 26, 2024

Uh oh!

elasticmachine commented Jun 26, 2024

Uh oh!

elasticmachine commented Jun 26, 2024

Uh oh!

elasticmachine commented Jun 26, 2024

Uh oh!

elasticmachine commented Jun 26, 2024

Uh oh!

elasticmachine commented Jun 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

milan-elastic commented May 28, 2024 •

edited

Loading

elasticmachine commented May 29, 2024 •

edited

Loading

Package `mysql` 👍(0) 💚(1) 💔(1)

Package `nginx` 👍(0) 💚(1) 💔(1)

Package `nginx_ingress_controller` 👍(1) 💚(0) 💔(1)

Package `oracle_weblogic` 👍(1) 💚(1) 💔(2)

Package `spring_boot` 👍(2) 💚(0) 💔(1)

agithomas commented Jun 18, 2024 •

edited

Loading