Skip to content

[suricata] Make event.original optional#991

Merged
marc-gr merged 1 commit intoelastic:masterfrom
marc-gr:suricata-eventoriginal
May 17, 2021
Merged

[suricata] Make event.original optional#991
marc-gr merged 1 commit intoelastic:masterfrom
marc-gr:suricata-eventoriginal

Conversation

@marc-gr
Copy link
Copy Markdown
Contributor

@marc-gr marc-gr commented May 14, 2021

What does this PR do?

Makes event.original optional

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

Related issues

Screenshots

image

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 14, 2021

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@marc-gr marc-gr force-pushed the suricata-eventoriginal branch from eb252cd to b098b98 Compare May 14, 2021 12:56
@marc-gr marc-gr mentioned this pull request May 14, 2021
Closed
43 tasks
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 14, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #991 updated

  • Start Time: 2021-05-14T12:57:10.882+0000

  • Duration: 14 min 39 sec

  • Commit: b098b98

Test stats 🧪

Test Results
Failed 0
Passed 27
Skipped 0
Total 27

Trends 🧪

Image of Build Times

Image of Tests

P1llus
P1llus approved these changes May 17, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-gr marc-gr merged commit 24b4447 into elastic:master May 17, 2021
@marc-gr marc-gr deleted the suricata-eventoriginal branch May 17, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@P1llus P1llus P1llus approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marc-gr @elasticmachine @P1llus