Skip to content

[Apache] Migrate package to spec v3#9818

Merged
jsoriano merged 9 commits intoelastic:mainfrom
jsoriano:apache-spec-v3
May 14, 2024
Merged

[Apache] Migrate package to spec v3#9818
jsoriano merged 9 commits intoelastic:mainfrom
jsoriano:apache-spec-v3

Conversation

@jsoriano
Copy link
Copy Markdown
Member

@jsoriano jsoriano commented May 8, 2024 •
edited
Loading

Proposed commit message

Migrate package to spec v3 so it is ready for serverless, this includes:

  • Add secrets support.
  • Remove duplicated and ambiguous field definitions.
  • Fix normalization as arrays of event.category and event.type fields.
  • Handle event.original in pipelines.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@jsoriano jsoriano self-assigned this May 8, 2024
@jsoriano jsoriano requested a review from a team as a code owner May 8, 2024 10:29
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 8, 2024 •
edited
Loading

🚀 Benchmarks report

Package apache 👍(0) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
access 4545.45 3484.32 -1061.13 (-23.34%) 💔
error 4405.29 2906.98 -1498.31 (-34.01%) 💔

To see the full report comment with /test benchmark fullreport

@jsoriano jsoriano mentioned this pull request May 8, 2024
Closed
96 tasks
@jsoriano jsoriano mentioned this pull request May 8, 2024
Merged
@jsoriano
Copy link
Copy Markdown
Member Author

jsoriano commented May 9, 2024

@lalit-satapathy @shmsr could I get a review here? Thanks!

shmsr
shmsr reviewed May 9, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@shmsr shmsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. But let's wait for someone from the team as well to give a +1 before we merge.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 9, 2024

💚 Build Succeeded

History

cc @jsoriano

@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube bot commented May 9, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@shmsr
Copy link
Copy Markdown
Member

shmsr commented May 9, 2024

@devamanv / @aliabbas-elastic Could you guys help to review this? For more context, this is similar to work done at #8028, secrets work, etc.

@jsoriano
Copy link
Copy Markdown
Member Author

jsoriano commented May 14, 2024

@shmsr @devamanv @aliabbas-elastic did you have the chance to take another look to this change? Would it be ready to merge?

ali786XI
ali786XI approved these changes May 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ali786XI ali786XI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the changes

@jsoriano jsoriano merged commit 5620eac into elastic:main May 14, 2024
@jsoriano jsoriano deleted the apache-spec-v3 branch May 14, 2024 11:51
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 14, 2024

Package apache - 1.18.0 containing this change is available at https://epr.elastic.co/search?package=apache

@gizas gizas mentioned this pull request Jun 18, 2024
Closed
@andrewkroh andrewkroh added the Integration:apache Apache HTTP Server label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shmsr shmsr shmsr approved these changes

+1 more reviewer

@ali786XI ali786XI ali786XI approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jsoriano jsoriano

Labels

Integration:apache Apache HTTP Server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[apache] convert legacy visualizations to lens Apache ingest pipeline doesn't tolerate existing "event.original" field

5 participants

@jsoriano @elasticmachine @shmsr @ali786XI @andrewkroh