Skip to content

[Azure_Functions] Remove add_cloud_metadata flag from the Agent config#9790

Merged
devamanv merged 3 commits intoelastic:mainfrom
devamanv:remove-cloud-metadata-azurefunctions
May 6, 2024
Merged

[Azure_Functions] Remove add_cloud_metadata flag from the Agent config#9790
devamanv merged 3 commits intoelastic:mainfrom
devamanv:remove-cloud-metadata-azurefunctions

Conversation

@devamanv
Copy link
Copy Markdown
Contributor

@devamanv devamanv commented May 6, 2024 •
edited by shmsr
Loading

Proposed commit message

The PR contains a change to remove theadd_cloud_metadata flag. As seen from the code, if set to true, the metricset tries to look for a VM using a dimension value or the actual resource ID. This isn't required for Azure Functions. Hence, it is being removed.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@devamanv devamanv requested a review from a team as a code owner May 6, 2024 14:58
@devamanv devamanv requested a review from zmoog May 6, 2024 15:03
zmoog
zmoog approved these changes May 6, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 6, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 6, 2024

💚 Build Succeeded

@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube bot commented May 6, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@devamanv devamanv self-assigned this May 6, 2024
@devamanv devamanv added the bugfix Pull request that fixes a bug issue label May 6, 2024
shmsr
shmsr approved these changes May 6, 2024
View reviewed changes
@shmsr shmsr changed the title [Azure_Functions] Remove Cloud Metadata flag from agent config [Azure_Functions] Remove add_cloud_metadata flag from the Agent config May 6, 2024
@muthu-mps
Copy link
Copy Markdown
Contributor

muthu-mps commented May 6, 2024

@devamanv - This fix is applied by considering that the Azure function doesn't have metadata information irrespective of the services used?

@zmoog
Copy link
Copy Markdown
Contributor

zmoog commented May 6, 2024 •
edited by devamanv
Loading

@devamanv - This fix is applied by considering that the Azure function doesn't have metadata information irrespective of the services used?

@muthu-mps The add_cloud_metadata in Azure Monitor targets VMs and VM-related resources (mostly VM scale sets), and it can't fetch metadata for Azure Functions.

@devamanv devamanv merged commit dbdf02b into elastic:main May 6, 2024
@devamanv devamanv deleted the remove-cloud-metadata-azurefunctions branch May 6, 2024 15:53
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented May 6, 2024

Package azure_functions - 0.4.1 containing this change is available at https://epr.elastic.co/search?package=azure_functions

@andrewkroh andrewkroh added the Integration:azure_functions Azure Functions label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmoog zmoog zmoog approved these changes

@shmsr shmsr shmsr approved these changes

@muthu-mps muthu-mps muthu-mps approved these changes

Assignees

@devamanv devamanv

Labels

bugfix Pull request that fixes a bug issue Integration:azure_functions Azure Functions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@devamanv @elasticmachine @muthu-mps @zmoog @shmsr @andrewkroh