Add global level data_stream.dataset dashboard filter#9768
Add global level data_stream.dataset dashboard filter#9768milan-elastic merged 20 commits intoelastic:mainfrom
Conversation
🚀 Benchmarks reportTo see the full report comment with |
|
Shouldn't the images of the dashboard be updated? |
|
Any reason why this change is considered an enhancement, not a bugfix? |
Adding filters would improve the performance of the dashboard. Currently, many integrations are working fine without dashboard-level filters and are not experiencing any issues. However, implementing filters at the dashboard level will enhance dashboard loading efficiency. Therefore, I am categorizing this as an enhancement rather than a bug fix. |
Yes, ideally it should be updated, but populating the dashboard with data that looks attractive for each package mentioned here would be a significant effort. From a visualization perspective, we are not making any changes; we are only adding a top-level filter. Therefore, I believe we shouldn't undertake this effort just to show the filter in the screenshot. Whenever there is a change in visualization, that person can update the screenshot accordingly. |
| "ignoreTimerange": false, | ||
| "ignoreValidations": false | ||
| }, | ||
| "panelsJSON": { |
There was a problem hiding this comment.
What change in the dashboard triggered this change in panelsJSON?
It changed from String to Object and that's what the CI is complaining about.
There was a problem hiding this comment.
Not sure, I've again tried to export it now and it is removed!
…-dataset-fitlers-dashboard-level
agithomas
left a comment
There was a problem hiding this comment.
LGTM, referring to the attached screenshot and the changes in the validations.yml
…-dataset-fitlers-dashboard-level
💚 Build Succeeded
History
|
|
|
Package activemq - 1.3.0 containing this change is available at https://epr.elastic.co/search?package=activemq |
|
Package airflow - 0.8.0 containing this change is available at https://epr.elastic.co/search?package=airflow |
|
Package apache - 1.19.0 containing this change is available at https://epr.elastic.co/search?package=apache |
|
Package apache_spark - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=apache_spark |
|
Package apache_tomcat - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=apache_tomcat |
|
Package cassandra - 1.13.0 containing this change is available at https://epr.elastic.co/search?package=cassandra |
|
Package ceph - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=ceph |
|
Package citrix_adc - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=citrix_adc |
|
Package cockroachdb - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=cockroachdb |
|
Package hadoop - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=hadoop |
Proposed commit message
Add a global filter to the dashboard and remove the subfilters on the dataset and a global filter on the dataset is introduced. Filters on data_stream.dataset are applied with a phrase type filter on the dataset that is being used in that particular dashboard.
Expect the above mentioned changes done in following selected packages to ease the review
Checklist
changelog.ymlfile.Related issues
Screenshot
ActiveMQ
Apache Spark
Apache Tomcat
Hadoop
Airflow
Apache
Cassandra
|
Ceph
Citrix ADC
CockroachDB