Skip to content

aws_logs: improve clarity and validity of system testing#9730

Merged
efd6 merged 2 commits intoelastic:mainfrom
efd6:aws_logs_testing
May 6, 2024
Merged

aws_logs: improve clarity and validity of system testing#9730
efd6 merged 2 commits intoelastic:mainfrom
efd6:aws_logs_testing

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Apr 29, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Integration:aws AWS labels Apr 29, 2024
@efd6 efd6 self-assigned this Apr 29, 2024
@efd6 efd6 force-pushed the aws_logs_testing branch 3 times, most recently from 63d70ba to 823c748 Compare April 29, 2024 02:30
@efd6 efd6 force-pushed the aws_logs_testing branch from 823c748 to 510ac0e Compare April 29, 2024 02:43
@efd6 efd6 marked this pull request as ready for review April 29, 2024 03:11
@efd6 efd6 requested a review from a team as a code owner April 29, 2024 03:11
@efd6 efd6 changed the title aws_logs: improve clarity and validity of sytem testing aws_logs: improve clarity and validity of system testing Apr 29, 2024
@efd6 efd6 enabled auto-merge (squash) April 29, 2024 03:12
@@ -1,3 +1,8 @@
- version: "1.3.0"
changes:
- description: Improve clarity and validity of sytem testing.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in "sytem".

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

cc @efd6

@elastic-sonarqube
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Copy Markdown
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for tidying this up!

@efd6 efd6 merged commit bbd94f6 into elastic:main May 6, 2024
@elasticmachine
Copy link
Copy Markdown

Package aws_logs - 1.3.0 containing this change is available at https://epr.elastic.co/search?package=aws_logs

@andrewkroh andrewkroh added Integration:aws_logs Custom AWS Logs and removed Integration:aws AWS labels Jul 22, 2024
@efd6 efd6 deleted the aws_logs_testing branch February 5, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:aws_logs Custom AWS Logs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants