Skip to content

Move PowerShell edge processing to ingest pipeline.#941

Merged
marc-gr merged 2 commits intoelastic:masterfrom
marc-gr:powershell-to-ingest
Apr 26, 2021
Merged

Move PowerShell edge processing to ingest pipeline.#941
marc-gr merged 2 commits intoelastic:masterfrom
marc-gr:powershell-to-ingest

Conversation

@marc-gr
Copy link
Copy Markdown
Contributor

@marc-gr marc-gr commented Apr 23, 2021 •
edited
Loading

What does this PR do?

Move PowerShell edge processing to ingest pipeline.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

Relates to

Closes #905

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Apr 23, 2021

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@marc-gr marc-gr force-pushed the powershell-to-ingest branch 2 times, most recently from 7c87383 to 7f8d15d Compare April 23, 2021 15:10
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Apr 23, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #941 updated

  • Start Time: 2021-04-26T07:32:44.574+0000

  • Duration: 12 min 48 sec

  • Commit: 16dec4c

Test stats 🧪

Test Results
Failed 0
Passed 38
Skipped 0
Total 38

Trends 🧪

Image of Build Times

Image of Tests

@marc-gr marc-gr force-pushed the powershell-to-ingest branch from 7f8d15d to 2f159e0 Compare April 23, 2021 15:17
leehinman
leehinman approved these changes Apr 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Might want to move the change to the system changelog out of this PR.

I think we need to find a way to make the argument parsing stuff reusable, this looks more resilient than what I have in the Security pipeline.

@marc-gr marc-gr force-pushed the powershell-to-ingest branch from 2f159e0 to 16dec4c Compare April 26, 2021 07:32
@marc-gr
Copy link
Copy Markdown
Contributor Author

marc-gr commented Apr 26, 2021

Looks great. Might want to move the change to the system changelog out of this PR.

I think we need to find a way to make the argument parsing stuff reusable, this looks more resilient than what I have in the Security pipeline.

Agreed. I think would be worth moving it to its own pipeline once this is done.

@marc-gr marc-gr merged commit 3867027 into elastic:master Apr 26, 2021
@marc-gr marc-gr deleted the powershell-to-ingest branch April 26, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leehinman leehinman leehinman approved these changes

Assignees

No one assigned

Labels

Integration:windows Windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Convert Windows's PowerShell edge processing to Ingest Node pipeline

3 participants

@marc-gr @elasticmachine @leehinman