Skip to content

[aws_logs] Enable secret variable for aws_logs integration#9019

Merged
kaiyan-sheng merged 5 commits intoelastic:mainfrom
kaiyan-sheng:secrets_aws_logs
Mar 19, 2024
Merged

[aws_logs] Enable secret variable for aws_logs integration#9019
kaiyan-sheng merged 5 commits intoelastic:mainfrom
kaiyan-sheng:secrets_aws_logs

Conversation

@kaiyan-sheng
Copy link
Copy Markdown

@kaiyan-sheng kaiyan-sheng commented Jan 31, 2024 •
edited
Loading

Proposed commit message

This PR is to enable secrets for identified sensitive fields and update package-spec to 3.0.2 to utilize the validation checks for secrets.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@kaiyan-sheng kaiyan-sheng self-assigned this Jan 31, 2024
@kaiyan-sheng kaiyan-sheng marked this pull request as ready for review February 20, 2024 21:41
@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner February 20, 2024 21:41
gizas
gizas reviewed Feb 22, 2024
View reviewed changes
@gizas
Copy link
Copy Markdown
Contributor

gizas commented Feb 22, 2024

Also kibana version should be ^8.12.0, see #9022

@kaiyan-sheng
Copy link
Copy Markdown
Author

kaiyan-sheng commented Feb 22, 2024

@gizas Yes I changed the kibana version back because I see some of the integrations are keeping the kibana version "For packages < 8.10.0, retain existing Kibana version. Changelog descriptions for these packages indicate that secrets are supported from version 8.12, allowing users to upgrade stack at their discretion." from #9009. But I think it's better to just bump the version to 8.12.0 anyway and make sure users adopt the secrets and password type. I just made the change in the latest commit. Thanks!

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Feb 22, 2024

💚 Build Succeeded

History

cc @kaiyan-sheng

@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube bot commented Feb 22, 2024

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@kaiyan-sheng kaiyan-sheng requested a review from gizas February 23, 2024 15:24
vigneshshanmugam
vigneshshanmugam approved these changes Mar 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaiyan-sheng kaiyan-sheng merged commit 008a7b7 into elastic:main Mar 19, 2024
@kaiyan-sheng kaiyan-sheng deleted the secrets_aws_logs branch March 19, 2024 19:23
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Mar 19, 2024

Package aws_logs - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=aws_logs

@andrewkroh andrewkroh added the Integration:aws_logs Custom AWS Logs label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

@zmoog zmoog Awaiting requested review from zmoog

@ritalwar ritalwar Awaiting requested review from ritalwar

@gizas gizas Awaiting requested review from gizas

Assignees

@kaiyan-sheng kaiyan-sheng

Labels

Integration:aws_logs Custom AWS Logs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kaiyan-sheng @gizas @elasticmachine @vigneshshanmugam @andrewkroh