feat [#8647]: mark linux integrations requiring root#8917
feat [#8647]: mark linux integrations requiring root#8917pkoutsovasilis merged 1 commit intomainfrom
Conversation
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
auditd |
10989.01 | 7092.2 | -3896.81 (-35.46%) | 💔 |
Package system_audit 👍(0) 💚(0) 💔(1)
Expand to view
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
package |
58823.53 | 47619.05 | -11204.48 (-19.05%) | 💔 |
To see the full report comment with /test benchmark fullreport
andrewkroh
left a comment
There was a problem hiding this comment.
Each package with changes will need a changelog entry. You can do it with the CLI via elastic-package change add.
packages/cloud_defend/manifest.yml
Outdated
| actions: [alert] | ||
| agent: | ||
| privileges: | ||
| root: false |
There was a problem hiding this comment.
With false being the default this could be entirely omitted.
There was a problem hiding this comment.
Sure my aim was explicitness and also kinda a notification to the sec-linux-platform team that this is getting marked as not requiring root. But what you say makes sense and I will omit that entirely
andrewkroh
left a comment
There was a problem hiding this comment.
I do suggest changing the description field to start with a capital and end with punctuation because these become user facing in our documentation (example https://docs.elastic.co/en/integrations/crowdstrike#changelog).
|
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
c110ae1 to
435f240
Compare
|
@andrewkroh please one more review 🙂 |
💚 Build Succeeded
History
|
|
This PR marks the appropriate linux integrations of [#8647] as requiring or not root
Related Issues