system: fix handling of tags in syslog datastream#8600
Merged
efd6 merged 1 commit intoelastic:mainfrom Nov 29, 2023
Merged
Conversation
In the case that the user has configured no tags, but has configured preserve original event, no tags configuration fields is included in the rendered configuration. This results in the preserve_original_event being added as a sub-array to the add_locale filebeat processor and apparently not failing, but not informing ingest to retain the event. It is not possible to test the fix here due to this absence of policy failure. Also fix exclude_files pattern in syslog and auth.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
andrewkroh
approved these changes
Nov 28, 2023
shmsr
approved these changes
Nov 29, 2023
Member
|
@efd6 : I think this would resolve the parsing of .gz files. Customer wants to make this configurable since they have other type of files they want to exclude. |
|
Package system - 1.49.1 containing this change is available at https://epr.elastic.co/search?package=system |
1 similar comment
|
Package system - 1.49.1 containing this change is available at https://epr.elastic.co/search?package=system |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
In the case that the user has configured no tags, but has configured preserve original event, no tags configuration fields is included in the rendered configuration. This results in the preserve_original_event being added as a sub-array to the add_locale filebeat processor and apparently not failing, but not informing ingest to retain the event. It is not possible to test the fix here due to this absence of policy failure.
Also fix exclude_files pattern in syslog and auth.
Note: this was tested manually.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots