Skip to content

[cisco_umbrella] Add system tests for aws-s3 input and fix fields#8388

Merged
bhapas merged 5 commits intoelastic:mainfrom
bhapas:cisco_umbrella_system_tests
Nov 3, 2023
Merged

[cisco_umbrella] Add system tests for aws-s3 input and fix fields#8388
bhapas merged 5 commits intoelastic:mainfrom
bhapas:cisco_umbrella_system_tests

Conversation

@bhapas
Copy link
Copy Markdown
Contributor

@bhapas bhapas commented Nov 2, 2023 •
edited
Loading

Proposed commit message

See Title

Checklist

- [ ] I have reviewed tips for building integrations and this pull request is aligned with them.
- [ ] I have verified that all data streams collect metrics or logs.

  • I have added an entry to my package's changelog.yml file.
    - [ ] I have verified that Kibana version constraints are current according to guidelines.

Related issues

Local testing

Need to add AWS credentials as env variables to be able to test this against AWS instance

export AWS_ACCESS_KEY_ID=<aws_access_key_id>
export AWS_SECRET_ACCESS_KEY=<aws_secret_access_key>
export AWS_SESSION_TOKEN=<aws_session_token>

@bhapas bhapas requested a review from a team as a code owner November 2, 2023 14:55
@bhapas bhapas force-pushed the cisco_umbrella_system_tests branch from 59cd654 to af68b1c Compare November 2, 2023 14:56
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 2, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-03T10:01:59.202+0000

  • Duration: 20 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 11
Skipped 0
Total 11

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@bhapas bhapas self-assigned this Nov 2, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 2, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 2, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (21/21) 💚
Lines 95.027% (535/563) 👎 -0.451
Conditionals 100.0% (0/0) 💚

@bhapas bhapas mentioned this pull request Nov 2, 2023
Closed
7 tasks
efd6
efd6 reviewed Nov 2, 2023
View reviewed changes
@bhapas bhapas requested a review from efd6 November 3, 2023 07:29
@bhapas bhapas force-pushed the cisco_umbrella_system_tests branch from 6420dca to 587411a Compare November 3, 2023 07:36
efd6
efd6 approved these changes Nov 3, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mod nit.

@bhapas
Copy link
Copy Markdown
Contributor Author

bhapas commented Nov 3, 2023

/test

@bhapas bhapas merged commit 474a599 into elastic:main Nov 3, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Nov 3, 2023

Package cisco_umbrella - 1.20.1 containing this change is available at https://epr.elastic.co/search?package=cisco_umbrella

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

@bhapas bhapas

Labels

Integration:cisco_umbrella Cisco Umbrella

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bhapas @elasticmachine @efd6