Dimension setting added to host.name in system package#8261
Dimension setting added to host.name in system package#8261ishleenk17 merged 9 commits intoelastic:mainfrom
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
| name: host.mac | ||
| - external: ecs | ||
| name: host.name | ||
| dimension: true |
There was a problem hiding this comment.
seems that in clean up PR dimension was set for the host.id field instead -
https://github.com/elastic/integrations/blob/main/packages/system/data_stream/memory/fields/agent.yml#L47-L49
I think for alignment it should be removed and we should keep host.name only
There was a problem hiding this comment.
Correct, I think the tool has added to host.id, removed from host.name
There was a problem hiding this comment.
For host.name, dimension was set to true in this commit. During cleanup in #8100, it removed the ip, mac, name fields (including sub-fields) but it left the dimension: true intact, and hence it moved up to host.id as a result.
Can we recheck if incomplete removal (e.g., leaving dimension) of duplicate fields didn't introduce any more such errors?
There was a problem hiding this comment.
Yeah @shmsr , I have already asked @tetianakravchenko to check that, since she had added them to system package.
There was a problem hiding this comment.
I've checked the cleanup PR - other dimension fields seems to be correct, no incomplete removal that affect the dimension: true
Co-authored-by: Tetiana Kravchenko <tanya.kravchenko.v@gmail.com>
Co-authored-by: Tetiana Kravchenko <tanya.kravchenko.v@gmail.com>
|
Left one more comment. |
|
Package system - 1.46.1 containing this change is available at https://epr.elastic.co/search?package=system |
Proposed commit message
This PR adds dimension setting host.name in diskio and memory datastream
Checklist
changelog.ymlfile.Related issues