Migrate obs-infraobs-integrations to package-spec v3 #4#8216
Merged
tommyers-elastic merged 8 commits intoelastic:mainfrom Oct 18, 2023
Merged
Conversation
The format_version in the package manifest changed from 2.8.0 to 3.0.0. Removed dotted YAML keys from package manifest. Added 'owner.type: elastic' to package manifest. [git-generate] go run github.com/andrewkroh/go-examples/ecs-update@latest -v -format-version=3.0.0 -fix-dotted-yaml-keys -add-owner-type packages/azure_app_service
The format_version in the package manifest changed from 2.0.0 to 3.0.0. Removed dotted YAML keys from package manifest. Added 'owner.type: elastic' to package manifest. [git-generate] go run github.com/andrewkroh/go-examples/ecs-update@latest -v -format-version=3.0.0 -fix-dotted-yaml-keys -add-owner-type packages/citrix_adc
The format_version in the package manifest changed from 1.0.0 to 3.0.0. Removed dotted YAML keys from package manifest. Added 'owner.type: elastic' to package manifest. [git-generate] go run github.com/andrewkroh/go-examples/ecs-update@latest -v -format-version=3.0.0 -fix-dotted-yaml-keys -add-owner-type packages/redis
The format_version in the package manifest changed from 1.0.0 to 3.0.0. Removed dotted YAML keys from package manifest. Added 'owner.type: elastic' to package manifest. [git-generate] go run github.com/andrewkroh/go-examples/ecs-update@latest -v -format-version=3.0.0 -fix-dotted-yaml-keys -add-owner-type packages/tomcat
96 tasks
shmsr
commented
Oct 16, 2023
shmsr
commented
Oct 16, 2023
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
packages/azure_app_service/data_stream/app_service_logs/fields/fields.yml
Show resolved
Hide resolved
| description: Number of bytes transmitted by an interface since the NetScaler appliance was started or the interface statistics were cleared. | ||
| metric_type: counter | ||
| unit: byte | ||
| # The following `interface` mappings are not allowed at root level in ECS, and are defined here for backward compatibility. |
tommyers-elastic
approved these changes
Oct 17, 2023
Contributor
tommyers-elastic
left a comment
There was a problem hiding this comment.
awesome - LGTM. thanks!
|
Package azure_app_service - 0.1.0 containing this change is available at https://epr.elastic.co/search?package=azure_app_service |
|
Package citrix_adc - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=citrix_adc |
|
Package redis - 1.12.0 containing this change is available at https://epr.elastic.co/search?package=redis |
|
Package tomcat - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=tomcat |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to this PR #8050 and @tommyers-elastic , could migrate 4 more packages
ECS dictates that that certain fields (geo, interface, os) should be nested and package validations were failing with these fields defined at root level. So from ecs.yml they are moved to fields.yml
Also refer: https://www.elastic.co/guide/en/ecs/current/ecs-field-reference.html
Proposed commit message
Migrate the following package to use package-spec v3:
Checklist
changelog.ymlfile.