Skip to content

[O11y][Stan] Migrate Channel Overview Metrics Dashboard Visualizations to Lens#8190

Merged
milan-elastic merged 2 commits intoelastic:mainfrom
milan-elastic:stan-metrics-overview-lens-migration
Oct 23, 2023
Merged

[O11y][Stan] Migrate Channel Overview Metrics Dashboard Visualizations to Lens#8190
milan-elastic merged 2 commits intoelastic:mainfrom
milan-elastic:stan-metrics-overview-lens-migration

Conversation

@milan-elastic
Copy link
Copy Markdown
Contributor

@milan-elastic milan-elastic commented Oct 13, 2023 •
edited
Loading

Urgency

  • High

Activity Type

  • Enhancement

What does this PR do?

  • Manually migrate Stan visualizations to the lens in the current Kibana version 8.10.2 itself.

  • Statistics for Stan Lens migration:

Migration stats

  Before Migration   After Migration  
  Lens Vizualization Lens Vizualization
[Metrics Stan] Channel Overview Metrics 0 2 2 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.10.2 itself.

Related issues

Screenshots

Before Migration:
metrics-stan-overview

After Migration:
metrics-stan-overview

@milan-elastic milan-elastic marked this pull request as ready for review October 13, 2023 10:39
@milan-elastic milan-elastic requested a review from a team as a code owner October 13, 2023 10:39
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Oct 13, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-13T10:23:37.843+0000

  • Duration: 19 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 25
Skipped 0
Total 25

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Oct 13, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.301
Classes 100.0% (1/1) 💚 3.301
Methods 100.0% (20/20) 💚 7.411
Lines 95.477% (190/199) 👍 7.088
Conditionals 100.0% (0/0) 💚

rajvi-patel-22
rajvi-patel-22 approved these changes Oct 16, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@rajvi-patel-22 rajvi-patel-22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@milan-elastic milan-elastic mentioned this pull request Oct 17, 2023
Closed
6 tasks
@tommyers-elastic
Copy link
Copy Markdown
Contributor

tommyers-elastic commented Oct 23, 2023

would it be possible to see before/after images over the same time period to directly compare the charts?

@milan-elastic
Copy link
Copy Markdown
Contributor Author

milan-elastic commented Oct 23, 2023

would it be possible to see before/after images over the same time period to directly compare the charts?

Done @tommyers-elastic I have updated the before/after screenshot in description now!

tommyers-elastic
tommyers-elastic approved these changes Oct 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@tommyers-elastic tommyers-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MichaelKatsoulis
MichaelKatsoulis approved these changes Oct 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@MichaelKatsoulis MichaelKatsoulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milan-elastic milan-elastic merged commit 908c564 into elastic:main Oct 23, 2023
@milan-elastic milan-elastic self-assigned this Oct 23, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Oct 23, 2023

Package stan - 1.3.4 containing this change is available at https://epr.elastic.co/search?package=stan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelKatsoulis MichaelKatsoulis MichaelKatsoulis approved these changes

@tommyers-elastic tommyers-elastic tommyers-elastic approved these changes

@gsantoro gsantoro Awaiting requested review from gsantoro gsantoro was automatically assigned from elastic/obs-cloudnative-monitoring

@tetianakravchenko tetianakravchenko Awaiting requested review from tetianakravchenko tetianakravchenko was automatically assigned from elastic/obs-cloudnative-monitoring

+1 more reviewer

@rajvi-patel-22 rajvi-patel-22 rajvi-patel-22 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@milan-elastic milan-elastic

Labels

Integration:stan STAN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@milan-elastic @elasticmachine @tommyers-elastic @MichaelKatsoulis @rajvi-patel-22