[aws] Remove unused aws.*.metrics.*.* and aws.s3.bucket.name#8140
Merged
kaiyan-sheng merged 6 commits intoelastic:mainfrom Oct 26, 2023
Merged
[aws] Remove unused aws.*.metrics.*.* and aws.s3.bucket.name#8140kaiyan-sheng merged 6 commits intoelastic:mainfrom
kaiyan-sheng merged 6 commits intoelastic:mainfrom
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
4 tasks
packages/aws/data_stream/s3_daily_storage/fields/package-fields.yml
Outdated
Show resolved
Hide resolved
Contributor
|
/test |
|
Package aws - 2.8.4 containing this change is available at https://epr.elastic.co/search?package=aws |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This PR is to remove unused
aws.*.metrics.*.*andaws.s3.bucket.namefrom package-fields.yml file.For some data streams when defining what metrics to collect from CloudWatch, specific metric names are listed. With the list of specific metrics,
aws.*.metrics.*.*is redundant. Some data stream when defining what metrics to collect, it only specifies the namespace for CloudWatch. That way we will keep theaws.*.metrics.*.*just in case AWS adds more metrics.For
aws.s3.bucket.nameit is only used ins3_daily_storageands3_requestdata streams in AWS integration. Will remove the rest.Checklist
changelog.ymlfile.