Skip to content

[System] Convert all legacy visualizations#8139

Merged
drewdaemon merged 8 commits intomainfrom
remove-legacy-system-vis
Oct 13, 2023
Merged

[System] Convert all legacy visualizations#8139
drewdaemon merged 8 commits intomainfrom
remove-legacy-system-vis

Conversation

@drewdaemon
Copy link
Copy Markdown
Contributor

@drewdaemon drewdaemon commented Oct 9, 2023 •
edited
Loading

Proposed commit message

Converts the remaining Legacy visualizations to Lens.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

SSH Login attempts

Before

ssh-login-attempts-legacy

After

ssh-login-attempst-after

Sudo commands

Before

sudo-before

After

sudo-after

New users and groups

Before

new-users-before

After

new-users-after

Syslog

Before

(didn't capture)

After

syslog-after

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Oct 9, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-09T21:50:18.277+0000

  • Duration: 17 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 151
Skipped 0
Total 151

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Oct 9, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 63.415% (52/82) 👍
Lines 99.863% (2924/2928) 👍
Conditionals 100.0% (0/0) 💚

@drewdaemon drewdaemon marked this pull request as ready for review October 10, 2023 00:52
@drewdaemon drewdaemon requested review from a team as code owners October 10, 2023 00:52
@efd6
Copy link
Copy Markdown
Contributor

efd6 commented Oct 10, 2023

Am I right in understanding that the SSH Login attempts after screen shot doesn't reflect all the changes here since it still has a tag cloud?

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Platform - Ingest - Agent [elastic/elastic-agent] label Oct 10, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Oct 10, 2023

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@dej611
Copy link
Copy Markdown

dej611 commented Oct 10, 2023

Am I right in understanding that the SSH Login attempts after screen shot doesn't reflect all the changes here since it still has a tag cloud?

Tag cloud is a visualization type supported by Lens. I've checked the SO and that is a Lens Tag cloud

@drewdaemon
Copy link
Copy Markdown
Contributor Author

drewdaemon commented Oct 10, 2023

You can quickly verify that there are no longer any legacy visualizations in this integration by changing the format_version to 3.0.0 in the manifest and then running elastic-package check. There will be a few dangling reference errors, but no legacy visualization reports.

mbondyra
mbondyra approved these changes Oct 10, 2023
View reviewed changes
Copy link
Copy Markdown

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Great job. I like that you changed the types from donut to treemaps too 👌🏼

marc-gr
marc-gr approved these changes Oct 13, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@marc-gr marc-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! LGTM

@drewdaemon drewdaemon merged commit 2a60eeb into main Oct 13, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Oct 13, 2023

Package system - 1.43.0 containing this change is available at https://epr.elastic.co/search?package=system

@marc-gr marc-gr deleted the remove-legacy-system-vis branch October 16, 2023 07:33
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Oct 17, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@belimawr belimawr belimawr approved these changes

@mbondyra mbondyra mbondyra approved these changes

@marc-gr marc-gr marc-gr approved these changes

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry fearful-symmetry was automatically assigned from elastic/elastic-agent-data-plane

Assignees

No one assigned

Labels

Integration:system System Team:Elastic-Agent Platform - Ingest - Agent [elastic/elastic-agent]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[System] remove legacy visualizations

9 participants

@drewdaemon @elasticmachine @efd6 @dej611 @belimawr @mbondyra @marc-gr @pierrehilbert @andrewkroh