Skip to content

[O11y][NATS] Migrate Metrics Overview dashboard visualizations to lens#8126

Merged
rajvi-patel-22 merged 2 commits intoelastic:mainfrom
rajvi-patel-22:lens_migration_nats_metrics
Oct 10, 2023
Merged

[O11y][NATS] Migrate Metrics Overview dashboard visualizations to lens#8126
rajvi-patel-22 merged 2 commits intoelastic:mainfrom
rajvi-patel-22:lens_migration_nats_metrics

Conversation

@rajvi-patel-22
Copy link
Copy Markdown
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Oct 9, 2023 •
edited
Loading

Urgency

  • High

Activity Type

  • Enhancement

What does this PR do?

  • Manually migrate Nats visualizations to the lens in the current Kibana version 8.10.2 itself.

  • Statistics for Nats Lens migration:

Migration stats

  Before Migration   After Migration  
  Lens Vizualization Lens Vizualization
[Metrics NATS] Overview 0 15 15 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.10.2 itself.

Related issues

Before Migration:
image

After Migration:
image

@rajvi-patel-22 rajvi-patel-22 self-assigned this Oct 9, 2023
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Oct 9, 2023
Closed
6 tasks
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Oct 9, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-10T08:47:13.382+0000

  • Duration: 30 min 0 sec

Test stats 🧪

Test Results
Failed 0
Passed 31
Skipped 2
Total 33

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Oct 9, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 5.556
Classes 100.0% (1/1) 💚 5.556
Methods 100.0% (29/29) 💚 13.953
Lines 95.522% (192/201) 👍 9.439
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22 rajvi-patel-22 marked this pull request as ready for review October 10, 2023 07:08
@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner October 10, 2023 07:08
milan-elastic
milan-elastic approved these changes Oct 10, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@milan-elastic milan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rajvi-patel-22 rajvi-patel-22 merged commit f016fa0 into elastic:main Oct 10, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Oct 10, 2023

Package nats - 1.3.4 containing this change is available at https://epr.elastic.co/search?package=nats

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@constanca-m constanca-m constanca-m approved these changes

@gizas gizas Awaiting requested review from gizas gizas was automatically assigned from elastic/obs-cloudnative-monitoring

+1 more reviewer

@milan-elastic milan-elastic milan-elastic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels

Integration:nats NATS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rajvi-patel-22 @elasticmachine @constanca-m @milan-elastic @andrewkroh