Skip to content

Fix Request Time lens and update image for AWS API Gateway#7990

Merged
lucian-ioan merged 8 commits intoelastic:mainfrom
lucian-ioan:fix_aws_apigateway_logs_dashboard
Sep 28, 2023
Merged

Fix Request Time lens and update image for AWS API Gateway#7990
lucian-ioan merged 8 commits intoelastic:mainfrom
lucian-ioan:fix_aws_apigateway_logs_dashboard

Conversation

@lucian-ioan
Copy link
Copy Markdown
Contributor

@lucian-ioan lucian-ioan commented Sep 27, 2023

Urgency

  • Medium

Activity Type

  • Bugfix

What does this PR do?

Fixes Request Time lens to accurately display the number of requests in a given timestamp.

"requestTime": "24/Sep/2023:17:07:44 +0000"

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Before:
filebeat-aws-apigateway-overview

After:
filebeat-aws-apigateway-overview

@lucian-ioan lucian-ioan self-assigned this Sep 27, 2023
@lucian-ioan lucian-ioan added Integration:aws AWS bugfix Pull request that fixes a bug issue labels Sep 27, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 27, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-28T18:47:14.975+0000

  • Duration: 54 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 212
Skipped 3
Total 215

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 27, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18) 👍
Classes 94.444% (17/18) 👍
Methods 86.047% (259/301) 👍
Lines 86.069% (7562/8786) 👍
Conditionals 100.0% (0/0) 💚

@lucian-ioan lucian-ioan marked this pull request as ready for review September 27, 2023 06:38
@lucian-ioan lucian-ioan requested review from a team as code owners September 27, 2023 06:38
Copy link
Copy Markdown
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest changing the title of the visualization to reflect that this is a count of requests.

Maybe something like
"Request Time" -> "Number of Requests"

@lucian-ioan
Copy link
Copy Markdown
Contributor Author

lucian-ioan commented Sep 28, 2023

I think that makes much more sense @drewdaemon.

Copy link
Copy Markdown
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucian-ioan lucian-ioan merged commit faef732 into elastic:main Sep 28, 2023
@elasticmachine
Copy link
Copy Markdown

Package aws - 2.6.1 containing this change is available at https://epr.elastic.co/search?package=aws

@lucian-ioan lucian-ioan deleted the fix_aws_apigateway_logs_dashboard branch February 6, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:aws AWS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Request Time lens in logs dashboard for AWS API Gateway

4 participants