Skip to content

[Cloudnative] Update null checks and if checks in the rename processor#7956

Merged
ishleenk17 merged 6 commits intoelastic:mainfrom
ishleenk17:cloudnative_event_original
Sep 26, 2023
Merged

[Cloudnative] Update null checks and if checks in the rename processor#7956
ishleenk17 merged 6 commits intoelastic:mainfrom
ishleenk17:cloudnative_event_original

Conversation

@ishleenk17
Copy link
Copy Markdown
Member

@ishleenk17 ishleenk17 commented Sep 25, 2023 •
edited
Loading

  • Bug

What does this PR do?

This PR adds the if check for event.original and the ignore_missing check for the renaming of message to event.original
The packages where the changes are made are as below:

  • istio
  • nats
  • nginx_ingress_controller
  • stan

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Testing

After adding the check if event.original is null, it takes value of message as shown below:
Screenshot 2023-09-26 at 3 20 28 PM

If event.original is present. For testing it was set in the pipeline itself as below:
Screenshot 2023-09-26 at 3 20 39 PM

As a result the event.original has the original value and not the message value.
Screenshot 2023-09-26 at 3 19 48 PM

Related issues

@ishleenk17 ishleenk17 requested a review from a team September 25, 2023 08:44
@ishleenk17 ishleenk17 self-assigned this Sep 25, 2023
@ishleenk17 ishleenk17 changed the title Cloudnative event original [Cloudnative] Update null checks and if checks in the rename processor Sep 25, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 25, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-25T11:39:30.158+0000

  • Duration: 31 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 123
Skipped 2
Total 125

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 25, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (7/7) 💚
Classes 100.0% (7/7) 💚
Methods 95.192% (99/104) 👍 3.526
Lines 95.818% (1054/1100) 👎 -4.182
Conditionals 100.0% (0/0) 💚

@ishleenk17 ishleenk17 marked this pull request as ready for review September 25, 2023 09:22
@ishleenk17 ishleenk17 requested a review from a team as a code owner September 25, 2023 09:22
gizas
gizas reviewed Sep 25, 2023
View reviewed changes
@gizas
Copy link
Copy Markdown
Contributor

gizas commented Sep 25, 2023

I would expect some test evidence like a grok test or sth that this change worked. Apart from that is ok.

@ishleenk17
Copy link
Copy Markdown
Member Author

ishleenk17 commented Sep 26, 2023

I would expect some test evidence like a grok test or sth that this change worked. Apart from that is ok.

I have added the testing to the PR description.

@ishleenk17 ishleenk17 merged commit 69f733a into elastic:main Sep 26, 2023
@ishleenk17 ishleenk17 mentioned this pull request Sep 26, 2023
Closed
35 tasks
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 26, 2023

Package istio - 0.4.2 containing this change is available at https://epr.elastic.co/search?package=istio

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 26, 2023

Package nats - 1.3.2 containing this change is available at https://epr.elastic.co/search?package=nats

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 26, 2023

Package nginx_ingress_controller - 1.7.3 containing this change is available at https://epr.elastic.co/search?package=nginx_ingress_controller

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 26, 2023

Package stan - 1.3.2 containing this change is available at https://epr.elastic.co/search?package=stan

@ishleenk17 ishleenk17 deleted the cloudnative_event_original branch February 7, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gizas gizas gizas approved these changes

@ChrsMark ChrsMark Awaiting requested review from ChrsMark ChrsMark was automatically assigned from elastic/obs-cloudnative-monitoring

@MichaelKatsoulis MichaelKatsoulis Awaiting requested review from MichaelKatsoulis MichaelKatsoulis was automatically assigned from elastic/obs-cloudnative-monitoring

Assignees

@ishleenk17 ishleenk17

Labels

Integration:istio Istio Integration:nats NATS Integration:nginx_ingress_controller Nginx Ingress Controller Logs Integration:stan STAN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ishleenk17 @elasticmachine @gizas @andrewkroh