Skip to content

[ti_rapid7] Update format_version to 3.0.0#7910

Merged
kcreddy merged 10 commits intoelastic:mainfrom
kcreddy:ti_rapid7_dlm
Sep 27, 2023
Merged

[ti_rapid7] Update format_version to 3.0.0#7910
kcreddy merged 10 commits intoelastic:mainfrom
kcreddy:ti_rapid7_dlm

Conversation

@kcreddy
Copy link
Copy Markdown
Contributor

@kcreddy kcreddy commented Sep 21, 2023 •
edited
Loading

What does this PR do?

  • Update format_version to 3.0.0
  • Add owner.type: elastic to package manifest.
  • Update indicator rules with predefined indices instead of all. i.e., with "auditbeat-*", "endgame-*", "filebeat-*", "logs-*", "packetbeat-*", "winlogbeat-*". These are the indices as per Prebuilt Indicator Match Rules installed by Elastic

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

@kcreddy kcreddy self-assigned this Sep 21, 2023
@kcreddy kcreddy added the enhancement New feature or request label Sep 21, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 21, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-26T13:29:45.248+0000

  • Duration: 16 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 23
Skipped 0
Total 23

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 21, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 88.372% (38/43) ❕
Lines 94.245% (868/921) ❕
Conditionals 100.0% (0/0) 💚

@kcreddy kcreddy marked this pull request as ready for review September 21, 2023 07:41
@kcreddy kcreddy requested a review from a team as a code owner September 21, 2023 07:41
@kcreddy kcreddy changed the title [ti_rapid7] Add DLM policy and update format_version to 3.0.0 [ti_rapid7] Update format_version to 3.0.0 Sep 21, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 21, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

andrewkroh
andrewkroh approved these changes Sep 22, 2023
View reviewed changes
@narph narph mentioned this pull request Sep 26, 2023
Closed
11 tasks
@mrodm
Copy link
Copy Markdown
Collaborator

mrodm commented Sep 26, 2023 •
edited
Loading

Please wait to merge this PR @kcreddy , merging this branch would publish this package as GA with spec v3 but this spec is not GA yet.

@andrewkroh could you check with your team in case there are more PRs updating format_version ? To try to avoid publishing more packages updating to format_version 3.0.0

We are checking how this validation is performed in elastic-package

Thanks!!

cc @jsoriano

@mrodm
Copy link
Copy Markdown
Collaborator

mrodm commented Sep 27, 2023

Please wait to merge this PR @kcreddy , merging this branch would publish this package as GA with spec v3 but this spec is not GA yet.

@andrewkroh could you check with your team in case there are more PRs updating format_version ? To try to avoid publishing more packages updating to format_version 3.0.0

We are checking how this validation is performed in elastic-package

Thanks!!

cc @jsoriano

@kcreddy you could proceed with this PR, just be aware that the spec v3 is not GA yet and there could be still changes in that version (e.g. more validation rules to be applied).

Just as a note, remember to add the capabilities if this package has some special requirement.

Sorry for the inconveniences

@kcreddy
Copy link
Copy Markdown
Contributor Author

kcreddy commented Sep 27, 2023

@kcreddy you could proceed with this PR, just be aware that the spec v3 is not GA yet and there could be still changes in that version (e.g. more validation rules to be applied).

Great, thanks for the confirmation!

Just as a note, remember to add the capabilities if this package has some special requirement.

I think as outlined in the meta issue for SEI packages, is to not specifically add capabilities

@kcreddy kcreddy merged commit 3cfd874 into elastic:main Sep 27, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 27, 2023

Package ti_rapid7_threat_command - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=ti_rapid7_threat_command

2 similar comments
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 27, 2023

Package ti_rapid7_threat_command - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=ti_rapid7_threat_command

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 27, 2023

Package ti_rapid7_threat_command - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=ti_rapid7_threat_command

@kcreddy kcreddy deleted the ti_rapid7_dlm branch February 7, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@kcreddy kcreddy

Labels

enhancement New feature or request Integration:ti_rapid7_threat_command Rapid7 Threat Command (Partner supported)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kcreddy @elasticmachine @mrodm @andrewkroh