Skip to content

[bitdefender,forcepoint_web,jumpcloud,tines] Remove version from ingest pipeline definitions#7807

Merged
andrewkroh merged 3 commits intoelastic:mainfrom
andrewkroh:bitdefender/bugfix/remove-ingest-pipeline-version
Sep 14, 2023
Merged

[bitdefender,forcepoint_web,jumpcloud,tines] Remove version from ingest pipeline definitions#7807
andrewkroh merged 3 commits intoelastic:mainfrom
andrewkroh:bitdefender/bugfix/remove-ingest-pipeline-version

Conversation

@andrewkroh
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh commented Sep 13, 2023 •
edited
Loading

The ingest node pipelines contained a version attribute that is not useful in Fleet pipelines. This will not be allowed in future versions of package-spec.

Relates: elastic/package-spec#529

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@andrewkroh andrewkroh added Team:Security-External Integrations Integration:forcepoint_web Forcepoint Web Security (Community supported) labels Sep 13, 2023
@andrewkroh andrewkroh requested a review from a team as a code owner September 13, 2023 21:55
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 13, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh andrewkroh added the Integration:bitdefender BitDefender (Community supported) label Sep 13, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 13, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-14T04:11:14.982+0000

  • Duration: 18 min 0 sec

Test stats 🧪

Test Results
Failed 0
Passed 43
Skipped 0
Total 43

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@andrewkroh
[bitdefender,forcepoint_web,jumpcloud] Remove version from ingest pip…
759ab32 
…eline definitions

The ingest node pipelines contained a version attribute that
is not useful in Fleet pipelines. This will not be allowed in future
versions of package-spec.

Relates: elastic/package-spec#529
@andrewkroh andrewkroh added the Integration:jumpcloud JumpCloud (Community supported) label Sep 13, 2023
@andrewkroh andrewkroh changed the title [bitdefender,forcepoint_web] Remove version from ingest pipeline definitions [bitdefender,forcepoint_web,jumpcloud] Remove version from ingest pipeline definitions Sep 13, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 13, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (7/7) 💚
Files 100.0% (7/7) 💚
Classes 100.0% (7/7) 💚
Methods 92.222% (83/90) 👎 -0.237
Lines 85.864% (1476/1719) 👎 -5.659
Conditionals 100.0% (0/0) 💚

efd6
efd6 reviewed Sep 13, 2023
View reviewed changes
@andrewkroh andrewkroh requested a review from efd6 September 14, 2023 01:47
efd6
efd6 reviewed Sep 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tines package is mentioned in the linked issue, and still has the version attribute. Is there a reason it is not included in this set of changes?

@andrewkroh andrewkroh mentioned this pull request Sep 14, 2023
Closed
11 tasks
@andrewkroh andrewkroh changed the title [bitdefender,forcepoint_web,jumpcloud] Remove version from ingest pipeline definitions [bitdefender,forcepoint_web,jumpcloud,tines] Remove version from ingest pipeline definitions Sep 14, 2023
@andrewkroh andrewkroh added the Integration:tines Tines (Community supported) label Sep 14, 2023
@andrewkroh andrewkroh merged commit 1a8a4b2 into elastic:main Sep 14, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 14, 2023

Package bitdefender - 1.3.1 containing this change is available at https://epr.elastic.co/search?package=bitdefender

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 14, 2023

Package forcepoint_web - 1.1.1 containing this change is available at https://epr.elastic.co/search?package=forcepoint_web

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 14, 2023

Package jumpcloud - 1.2.2 containing this change is available at https://epr.elastic.co/search?package=jumpcloud

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 14, 2023

Package tines - 1.2.1 containing this change is available at https://epr.elastic.co/search?package=tines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

No one assigned

Labels

Integration:bitdefender BitDefender (Community supported) Integration:forcepoint_web Forcepoint Web Security (Community supported) Integration:jumpcloud JumpCloud (Community supported) Integration:tines Tines (Community supported)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewkroh @elasticmachine @efd6