Skip to content

[O11y][Azure Metrics] Migrate Storage Overview dashboard to lens.#7691

Merged
kush-elastic merged 2 commits intoelastic:mainfrom
kush-elastic:7434-Storage-Overview-lens-migration
Sep 8, 2023
Merged

[O11y][Azure Metrics] Migrate Storage Overview dashboard to lens.#7691
kush-elastic merged 2 commits intoelastic:mainfrom
kush-elastic:7434-Storage-Overview-lens-migration

Conversation

@kush-elastic
Copy link
Copy Markdown
Contributor

@kush-elastic kush-elastic commented Sep 7, 2023 •
edited
Loading

Urgency

  • High

Activity Type

  • Enhancement

What does this PR do?

  • Manually migrate Azure Storage visualizations to the lens in the current Kibana version 8.9.0 itself.

  • Statistics for Azure Storage Lens migration:

Migration stats

  Before Migration     After Migration    
  Lens Visualization Old Input Controls Lens Visualization New control panels
[Azure Metrics] Table Storage Overview 0 9 1 9 0 1

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.4.0 itself.

Related issues

Before Migration
image

After Migration
image

@kush-elastic kush-elastic requested review from a team and rajvi-patel-22 September 7, 2023 04:28
@kush-elastic kush-elastic marked this pull request as ready for review September 7, 2023 04:28
@kush-elastic kush-elastic requested a review from a team as a code owner September 7, 2023 04:28
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 7, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-07T04:29:04.393+0000

  • Duration: 14 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 34
Skipped 0
Total 34

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 7, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 75.758% (25/33) 👎 -16.701
Lines 100.0% (32/32) 💚 8.498
Conditionals 100.0% (0/0) 💚

zmoog

This comment was marked as resolved.

Sign in to view

zmoog
zmoog reviewed Sep 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems to focus on general storage overview dashboard, but the description contains the Storage Table dashboard, isn't it?

zmoog
zmoog approved these changes Sep 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file in the PR is the right one.

@kush-elastic, could you replace the screenshots in the PR description before merging it?

@kush-elastic
Copy link
Copy Markdown
Contributor Author

kush-elastic commented Sep 8, 2023

The file in the PR is the right one.

@kush-elastic, could you replace the screenshots in the PR description before merging it?

Thanks for the review, I have updated the Screen Shots.

@kush-elastic kush-elastic merged commit f72d676 into elastic:main Sep 8, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 8, 2023

Package azure_metrics - 1.0.37 containing this change is available at https://epr.elastic.co/search?package=azure_metrics

@kush-elastic kush-elastic mentioned this pull request Sep 13, 2023
Closed
8 tasks
@andrewkroh andrewkroh added the Integration:azure_metrics Azure Resource Metrics label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmoog zmoog zmoog approved these changes

@rajvi-patel-22 rajvi-patel-22 Awaiting requested review from rajvi-patel-22

Assignees

No one assigned

Labels

Integration:azure_metrics Azure Resource Metrics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kush-elastic @elasticmachine @zmoog @andrewkroh