Skip to content

[Azure Logs] Clean up dashboard titles and descriptions#7525

Merged
lucian-ioan merged 5 commits intoelastic:mainfrom
lucian-ioan:cleanup_azure_dashboards_description
Aug 25, 2023
Merged

[Azure Logs] Clean up dashboard titles and descriptions#7525
lucian-ioan merged 5 commits intoelastic:mainfrom
lucian-ioan:cleanup_azure_dashboards_description

Conversation

@lucian-ioan
Copy link
Copy Markdown
Contributor

@lucian-ioan lucian-ioan commented Aug 24, 2023 •
edited
Loading

Urgency

  • Low

Activity Type

  • Enhancement

What does this PR do?

The aim of this PR is to fix/enhance titles and descriptions for the Azure Logs dashboards due to inconsistencies:

  • [Logs Azure] Azure Spring Cloud Logs Overview -> redo description
  • [Logs Azure] Azure Spring Cloud Logs System Logs -> redo description
  • [Logs Azure] Alerts Overview -> add dot at the end of description
  • [Logs Azure] Firewall Overview -> fix description (Azure instead of AWS)
  • [Logs Azure] Azure AD Identity Protection -> redo description (duplicate)
  • [Logs Azure] Azure AD Provisioning Logs -> redo description (duplicate)
  • [Logs Azure] Firewall Network Rule Log -> fix description (Azure instead of AWS)
  • [Logs Azure] Azure Spring Cloud Logs Application Console Logs -> add description/fix title

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Add the Azure Logs integration and check the dashboards titles/descriptions.

Related issues

Closes #7384

@lucian-ioan lucian-ioan requested a review from a team as a code owner August 24, 2023 07:59
@lucian-ioan lucian-ioan self-assigned this Aug 24, 2023
@lucian-ioan lucian-ioan added bugfix Pull request that fixes a bug issue enhancement New feature or request Integration:azure Azure Logs labels Aug 24, 2023
@lucian-ioan lucian-ioan requested a review from a team August 24, 2023 08:07
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 24, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-24T11:38:21.332+0000

  • Duration: 15 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 83
Skipped 0
Total 83

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 24, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 86.364% (19/22) 👎 -13.636
Classes 86.364% (19/22) 👎 -13.636
Methods 83.333% (155/186) 👎 -16.667
Lines 85.003% (2817/3314) 👎 -14.997
Conditionals 100.0% (0/0) 💚

zmoog
zmoog approved these changes Aug 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lucian-ioan lucian-ioan merged commit 750464b into elastic:main Aug 25, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 25, 2023

Package azure - 1.5.29 containing this change is available at https://epr.elastic.co/search?package=azure

@lucian-ioan lucian-ioan deleted the cleanup_azure_dashboards_description branch September 6, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmoog zmoog zmoog approved these changes

Assignees

@lucian-ioan lucian-ioan

Labels

bugfix Pull request that fixes a bug issue enhancement New feature or request Integration:azure Azure Logs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Azure Logs] Clean up dashboard titles and descriptions

3 participants

@lucian-ioan @elasticmachine @zmoog