Skip to content

Bump up the stack to 7.13#745

Merged
mtojek merged 9 commits intoelastic:masterfrom
mtojek:bump-up-stack-7.13
Feb 25, 2021
Merged

Bump up the stack to 7.13#745
mtojek merged 9 commits intoelastic:masterfrom
mtojek:bump-up-stack-7.13

Conversation

@mtojek
Copy link
Copy Markdown
Contributor

@mtojek mtojek commented Feb 25, 2021

What does this PR do?

This PR updates the dependency on elastic-package to use the 7.13.0-SNAPSHOT stack.

Checklist

- [ ] I have reviewed [tips for building integrations](https://github.com/elastic/integrations/blob/master/docs/tips_for_building_integrations.md) and this pull request is aligned with them.
- [ ] I have verified that all data streams collect metrics or logs.
- [ ] I have added an entry to my package's changelog.yml file.

How to test this PR locally

CI will verify it.

@mtojek mtojek requested a review from ycombinator February 25, 2021 10:21
@mtojek mtojek self-assigned this Feb 25, 2021
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Feb 25, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #745 updated

  • Start Time: 2021-02-25T14:18:14.289+0000

  • Duration: 41 min 31 sec

  • Commit: 4b056cd

Test stats 🧪

Test Results
Failed 0
Passed 1723
Skipped 3
Total 1726

Trends 🧪

Image of Build Times

Image of Tests

@mtojek
Copy link
Copy Markdown
Contributor Author

mtojek commented Feb 25, 2021

It looks like I discovered more fields in 7.13.0-SNAPSHOT for the Kubernetes integration: https://beats-ci.elastic.co/blue/organizations/jenkins/Ingest-manager%2Fintegrations/detail/PR-745/1/tests

@mtojek mtojek force-pushed the bump-up-stack-7.13 branch from 84ac4db to 107f797 Compare February 25, 2021 11:31
@mtojek mtojek requested a review from ChrsMark February 25, 2021 12:16
ChrsMark
ChrsMark reviewed Feb 25, 2021
View reviewed changes
Comment thread packages/kubernetes/data_stream/state_node/fields/fields.yml Outdated
description: |
Node unschedulable status
- name: disk_pressure
type: boolean
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark Feb 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking into this I found we have an issue with the mapping. Opened a PR to fix it: elastic/beats#24241. Would you mind to adjust this one accordingly?

Copy link
Copy Markdown
Contributor Author

@mtojek mtojek Feb 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't do it right now due to type check (expecting boolean). We can do it later, unfortunately, once master starts failing. Keep in mind that we'll have to wait for the Beats and Agent's image to be built first.

Copy link
Copy Markdown
Member

@ChrsMark ChrsMark Feb 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right!

Copy link
Copy Markdown
Contributor Author

@mtojek mtojek Feb 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this issue privately, seems that it should be keyword (values: true, false, unknown). I will try to adjust the PR.

@mtojek mtojek mentioned this pull request Feb 25, 2021
Merged
ChrsMark
ChrsMark approved these changes Feb 25, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, only one nit. Thanks!

Comment thread packages/kubernetes/data_stream/state_node/fields/fields.yml Outdated
Comment thread packages/kubernetes/data_stream/state_node/fields/fields.yml Outdated
Comment thread packages/kubernetes/data_stream/state_node/fields/fields.yml Outdated
ChrsMark
ChrsMark approved these changes Feb 25, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mtojek mtojek merged commit e0bea4b into elastic:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

@ycombinator ycombinator Awaiting requested review from ycombinator

Assignees

@mtojek mtojek

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mtojek @elasticmachine @ChrsMark