Skip to content

windows: retain winlog.event_data.Details#7396

Merged
efd6 merged 1 commit intoelastic:mainfrom
efd6:7310-windows
Aug 28, 2023
Merged

windows: retain winlog.event_data.Details#7396
efd6 merged 1 commit intoelastic:mainfrom
efd6:7310-windows

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Aug 16, 2023 •
edited
Loading

What does this PR do?

See title. The field is retained because it may contain information that is useful.

The winlog.event_data.Detail field is dropped from the definitions as it is not used and is likely there as a typo of ….Details.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Aug 16, 2023
@efd6 efd6 force-pushed the 7310-windows branch 2 times, most recently from 0ba4918 to 10571e0 Compare August 16, 2023 00:37
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 16, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-24T00:59:02.180+0000

  • Duration: 19 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 150
Skipped 0
Total 150

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 16, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (8/8) 💚
Files 91.667% (11/12) 👎 -4.983
Classes 91.667% (11/12) 👎 -4.983
Methods 85.156% (109/128) 👎 -6.707
Lines 92.459% (5726/6193) 👍 4.141
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review August 16, 2023 00:59
@efd6 efd6 requested review from a team as code owners August 16, 2023 00:59
@efd6 efd6 requested review from faec and fearful-symmetry August 16, 2023 00:59
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 16, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

kcreddy
kcreddy approved these changes Aug 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@efd6 efd6 merged commit 60ba741 into elastic:main Aug 28, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 28, 2023

Package windows - 1.33.0 containing this change is available at https://epr.elastic.co/search?package=windows

@efd6 efd6 deleted the 7310-windows branch February 5, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kcreddy kcreddy kcreddy approved these changes

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry fearful-symmetry is a code owner automatically assigned from elastic/elastic-agent-data-plane

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@efd6 efd6

Labels

enhancement New feature or request Integration:windows Windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhance Windows Integration: Save winlog.event_data.Details to ECS Field

3 participants

@efd6 @elasticmachine @kcreddy