Skip to content

Replacing .json pipeline test config files with .yml ones#739

Merged
ycombinator merged 8 commits intoelastic:masterfrom
ycombinator:pipeline-test-configs-yaml
Mar 2, 2021
Merged

Replacing .json pipeline test config files with .yml ones#739
ycombinator merged 8 commits intoelastic:masterfrom
ycombinator:pipeline-test-configs-yaml

Conversation

@ycombinator
Copy link
Copy Markdown
Contributor

@ycombinator ycombinator commented Feb 22, 2021

What does this PR do?

This PR replaces all .json pipeline test configuration files with equivalent *.yml ones. This ensures that all package-related configuration files are consistently in YAML format.

Related issues

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Feb 23, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: ycombinator commented: jenkins, run the tests please

  • Start Time: 2021-03-02T01:32:29.185+0000

  • Duration: 37 min 53 sec

  • Commit: 388c600

Test stats 🧪

Test Results
Failed 0
Passed 1723
Skipped 3
Total 1726

Trends 🧪

Image of Build Times

Image of Tests

@andresrc andresrc added the Team:Integrations Label for the Integrations team label Feb 23, 2021
@ycombinator ycombinator force-pushed the pipeline-test-configs-yaml branch from 54516ca to d81301d Compare February 25, 2021 18:42
@ycombinator
Copy link
Copy Markdown
Contributor Author

CI is failing on pipeline tests for the zoom integration. These failures are legitimate and will be resolved once elastic/elastic-package#264 is merged and the elastic-package dependency in this PR is updated.

@ycombinator ycombinator force-pushed the pipeline-test-configs-yaml branch from 2e03afb to 6d915a8 Compare March 1, 2021 16:17
@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Mar 1, 2021

@mtojek looks like the new static tests are failing for some packages in CI. Is this to be expected? I've rebased this PR on master and master CI is currently green. 🤔

@ycombinator
Copy link
Copy Markdown
Contributor Author

@mtojek Re: my previous comment, I guess we will need #754 to be merged first and then this PR here will need to be rebased on master again.

@ycombinator
Copy link
Copy Markdown
Contributor Author

@mtojek Actually I just updated the elastic-package dependency in this PR's go.mod again to point to a slightly older release (elastic/elastic-package@adf9302). That release does not include the static test runner changes, which are not needed for this PR anyway.

@ycombinator ycombinator marked this pull request as ready for review March 1, 2021 22:00
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/integrations (Team:Integrations)

@ycombinator ycombinator requested a review from mtojek March 1, 2021 22:00
@ycombinator
Copy link
Copy Markdown
Contributor Author

jenkins, run the tests please

@mtojek
Copy link
Copy Markdown
Contributor

mtojek commented Mar 2, 2021

@mtojek Actually I just updated the elastic-package dependency in this PR's go.mod again to point to a slightly older release (elastic/elastic-package@adf9302). That release does not include the static test runner changes, which are not needed for this PR anyway.

Yes, that's why I pushed the static test runner, it's not really blocking :) Sorry for the confusion.

@ycombinator ycombinator merged commit 2b70a54 into elastic:master Mar 2, 2021
@ycombinator ycombinator deleted the pipeline-test-configs-yaml branch March 2, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Integrations Label for the Integrations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants