Use correct types for source.port and source.ip#737
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
| name: apache | ||
| title: Apache | ||
| version: 0.3.3 | ||
| version: 0.3.4 |
There was a problem hiding this comment.
Just want to confirm that we want to bump up the version just for this change, causing it to get released immediately? The alternative would be to make this change but not release it right away so other changes can accumulate for 0.3.4 before it is released.
There was a problem hiding this comment.
I think this is a bug fix and it would be good to push the change sooner than later.
ycombinator
left a comment
There was a problem hiding this comment.
Change LGTM. Just have a question about whether we want to release it right away or later.
packages/apache/changelog.yml
Outdated
| - version: "0.3.4" | ||
| changes: | ||
| - description: Use correct types for `source.port` and `source.ip` | ||
| type: enhancement |
There was a problem hiding this comment.
Sounds like this should be bugfix?
It would be great to make this PR happy first, let's wait for the fix for Elastic Agent. |
|
Pinging @elastic/integrations (Team:Integrations) |
|
/test |
|
jenkins run the tests please |
|
Blocked by: elastic/beats#24163 |
This PR adjusts the Apache intergration to use correct types for
source.portandsource.ip.What does this PR do?
Different field mappings caused conflicts.
Checklist
changelog.ymlfile.How to test this PR locally
Related issues