Skip to content

[Windows] Enable TSDB for service metrics dataset.#7206

Merged
ritalwar merged 7 commits intoelastic:mainfrom
ritalwar:windows_tsdb_enable_6993
Sep 13, 2023
Merged

[Windows] Enable TSDB for service metrics dataset.#7206
ritalwar merged 7 commits intoelastic:mainfrom
ritalwar:windows_tsdb_enable_6993

Conversation

@ritalwar
Copy link
Copy Markdown
Contributor

@ritalwar ritalwar commented Aug 1, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

This PR enables TSDB by default for Windows service datastream.
Reference to a blog post that elaborates on the performance enhancements achieved with TSDB.

How to test this PR locally

  • 1. Setup Windows VM

  • 2. Build verification
    elastic-package build
    elastic-package stack up -v -d --services package-registry

  • 3. Document count verification after TSDB enablement

  • 4. Dashboard verification after enablement.

  • 5. Index template verification

  • 6. Index mapping verification

  • 7. Index settings verification.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Refer #6993

@ritalwar ritalwar requested review from a team as code owners August 1, 2023 13:43
@ritalwar ritalwar requested review from faec and rdner August 1, 2023 13:43
@ritalwar ritalwar mentioned this pull request Aug 1, 2023
Closed
6 tasks
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 1, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-06T10:11:43.955+0000

  • Duration: 29 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 150
Skipped 0
Total 150

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 28, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (8/8) 💚
Files 91.667% (11/12) 👎 -8.333
Classes 91.667% (11/12) 👎 -8.333
Methods 85.156% (109/128) 👎 -14.844
Lines 91.55% (5840/6379) 👎 -4.212
Conditionals 100.0% (0/0) 💚

rdner
rdner reviewed Sep 4, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rdner rdner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please list the testing steps you've taken to validate it working? Would be nice to have it in the description.

@ritalwar
Copy link
Copy Markdown
Contributor Author

ritalwar commented Sep 4, 2023 •
edited
Loading

Could you please list the testing steps you've taken to validate it working? Would be nice to have it in the description.

Please check this reference.
I've also made updates to the description of this ticket.

@ritalwar ritalwar requested a review from rdner September 4, 2023 08:42
rdner
rdner approved these changes Sep 4, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@rdner rdner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM, however I'd like to see a link that supports this claim in the changelog:

This dramatically reduces storage for metrics and is expected to progressively improve query performance.

@mlunadia
Copy link
Copy Markdown

mlunadia commented Sep 5, 2023

The change LGTM, however I'd like to see a link that supports this claim in the changelog:

This dramatically reduces storage for metrics and is expected to progressively improve query performance.

@ritalwar if links can be added to the changelog please use this one https://www.elastic.co/blog/70-percent-storage-savings-for-metrics-with-elastic-observability

leehinman
leehinman approved these changes Sep 12, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I was able to install on Windows Server 2022, ingest worked fine and Dashboards worked fine.

lalit-satapathy
lalit-satapathy reviewed Sep 13, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@lalit-satapathy lalit-satapathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritalwar ritalwar merged commit f212ba0 into elastic:main Sep 13, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Sep 13, 2023

Package windows - 1.36.0 containing this change is available at https://epr.elastic.co/search?package=windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdner rdner rdner approved these changes

@leehinman leehinman leehinman approved these changes

@lalit-satapathy lalit-satapathy lalit-satapathy approved these changes

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

No one assigned

Labels

Integration:windows Windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Windows TSDB Enablement

7 participants

@ritalwar @elasticmachine @mlunadia @rdner @leehinman @lalit-satapathy @andrewkroh