Skip to content

[Windows] Add dimension fields for service datastream to support TSDB.#7172

Merged
ritalwar merged 10 commits intoelastic:mainfrom
ritalwar:windows_tsdb_dimension_service_6993
Aug 28, 2023
Merged

[Windows] Add dimension fields for service datastream to support TSDB.#7172
ritalwar merged 10 commits intoelastic:mainfrom
ritalwar:windows_tsdb_dimension_service_6993

Conversation

@ritalwar
Copy link
Copy Markdown
Contributor

@ritalwar ritalwar commented Jul 28, 2023

  • Enhancement

What does this PR do?

This PR adds dimension fields for service datastream to support TSDB enablement.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@ritalwar ritalwar requested review from a team as code owners July 28, 2023 05:58
@ritalwar ritalwar marked this pull request as draft July 28, 2023 05:58
@ritalwar ritalwar marked this pull request as ready for review July 28, 2023 06:02
@ritalwar ritalwar mentioned this pull request Jul 28, 2023
Closed
6 tasks
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 28, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-28T09:48:09.707+0000

  • Duration: 20 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 150
Skipped 0
Total 150

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 28, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (8/8) 💚
Files 91.667% (11/12) 👍
Classes 91.667% (11/12) 👍
Methods 85.156% (109/128) 👍
Lines 92.459% (5726/6193) 👍
Conditionals 100.0% (0/0) 💚

@agithomas
Copy link
Copy Markdown
Contributor

agithomas commented Jul 28, 2023

@ritalwar , there exist only one field - uptime.ms having a metric value. Is there merit in doing TSDB enablement for this datastream?

cc @lalit-satapathy

@lalit-satapathy
Copy link
Copy Markdown
Contributor

lalit-satapathy commented Jul 28, 2023

@ritalwar , there exist only one field - uptime.ms having a metric value. Is there merit in doing TSDB enablement for this datastream?

cc @lalit-satapathy

Single field metric document is fine. What metric type is uptime.ms? @ritalwar Can you share a sample service data stream document below?

@ritalwar
Copy link
Copy Markdown
Contributor Author

ritalwar commented Jul 28, 2023 •
edited
Loading

@ritalwar , there exist only one field - uptime.ms having a metric value. Is there merit in doing TSDB enablement for this datastream?
cc @lalit-satapathy

Single field metric document is fine. What metric type is uptime.ms? @ritalwar Can you share a sample service data stream document below?

uptime is the time duration since the service was last started, and uptime.ms is the service's uptime specified in milliseconds.

Here is the sample doc:

{
    "data_stream": {
      "dataset": "windows.service",
      "namespace": "default",
      "type": "metrics"
    },
    "service": {
      "type": "windows"
    },
    "windows": {
      "service": {
        "display_name": "Distributed Transaction Coordinator",
        "id": "-VO2Lm89v4",
        "name": "MSDTC",
        "path_name": "C:\\Windows\\System32\\msdtc.exe",
        "pid": 11592,
        "start_name": "NT AUTHORITY\\NetworkService",
        "start_type": "Automatic (Delayed)",
        "state": "Running",
        "uptime": {
          "ms": 767641828
        }
      }
    }
  }

agithomas
agithomas approved these changes Jul 31, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lalit-satapathy
Copy link
Copy Markdown
Contributor

lalit-satapathy commented Jul 31, 2023 •
edited by ritalwar
Loading

Single field metric document is fine. What metric type is uptime.ms? @ritalwar Can you share a sample service data stream document below?

What metric type for uptime.ms?
gauge, shall I make this metric_type change in the same PR?

@harnish-crest-data
Copy link
Copy Markdown
Contributor

harnish-crest-data commented Aug 22, 2023

@ritalwar, I have performed the TSDB-enablement-test-kit with this PR (including the metric_type field changes). The package is working fine. LGTM!

image

@ritalwar ritalwar merged commit bd2937d into elastic:main Aug 28, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Aug 28, 2023

Package windows - 1.34.0 containing this change is available at https://epr.elastic.co/search?package=windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@belimawr belimawr belimawr approved these changes

@agithomas agithomas agithomas approved these changes

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry fearful-symmetry is a code owner automatically assigned from elastic/elastic-agent-data-plane

@lalit-satapathy lalit-satapathy Awaiting requested review from lalit-satapathy

+1 more reviewer

@harnish-crest-data harnish-crest-data harnish-crest-data approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Integration:windows Windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ritalwar @elasticmachine @agithomas @lalit-satapathy @harnish-crest-data @belimawr @andrewkroh