You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have reviewed tips for building integrations and this pull request is aligned with them. - [ ] I have verified that all data streams collect metrics or logs. - [ ] I have added an entry to my package's changelog.yml file. - [ ] I have verified that Kibana version constraints are current according to guidelines.
How to test this PR locally
Setup AWS credentials and add AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY to the env vars.
Navigate to packages/aws_logs
Spin up elastic stack using elastic-package stack up -d -v
Run tests using elastic-package test system -v
Take down elastic stack elastic-package stack down -v
@bhapas Thank you so much for working on this! Quick question, are we testing logs ingestion using aws-s3 input here? Are we sending any sample log into S3 bucket and expect a notification message generated in SQS queue and read by the aws-s3 input?
@bhapas Thank you so much for working on this! Quick question, are we testing logs ingestion using aws-s3 input here? Are we sending any sample log into S3 bucket and expect a notification message generated in SQS queue and read by the aws-s3 input?
@kaiyan-sheng Yes.. So , we have an S3 and SQS and when some object is Put into S3 , an SQS Notification is configured and the integration reads the logs through SQS queue_url. The queue_url is dynamically generated by terraform and is read through the system test config using handlebars template like queue_url: '{{TF_OUTPUT_queue_url}}'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
system testsforawss3input inaws_logsintegrationWhat does this PR do?
Adds system test by using
terraform service deployerand using theSQS queue_urlgenerated interraform outputs.Created test after the implementation of elastic/elastic-package#1272
Checklist
- [ ] I have verified that all data streams collect metrics or logs.- [ ] I have added an entry to my package'schangelog.ymlfile.- [ ] I have verified that Kibana version constraints are current according to guidelines.How to test this PR locally
AWS_ACCESS_KEY_IDandAWS_SECRET_ACCESS_KEYto the env vars.packages/aws_logselastic-package stack up -d -velastic-package test system -velastic-package stack down -v