Skip to content

[ti_misp] Skip rename if "event.original" already exists#7026

Merged
bhapas merged 2 commits intoelastic:mainfrom
bhapas:ti-misp-event-original-bug
Jul 20, 2023
Merged

[ti_misp] Skip rename if "event.original" already exists#7026
bhapas merged 2 commits intoelastic:mainfrom
bhapas:ti-misp-event-original-bug

Conversation

@bhapas
Copy link
Copy Markdown
Contributor

@bhapas bhapas commented Jul 20, 2023 •
edited
Loading

What does this PR do?

This PR checks the pre existence of event.original field in the incoming event.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
    - [ ] I have verified that Kibana version constraints are current according to guidelines.

Related issues

@bhapas bhapas added Team:Security-External Integrations bugfix Pull request that fixes a bug issue labels Jul 20, 2023
@bhapas bhapas self-assigned this Jul 20, 2023
@bhapas bhapas marked this pull request as ready for review July 20, 2023 07:40
@bhapas bhapas requested a review from a team as a code owner July 20, 2023 07:40
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 20, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@bhapas bhapas changed the title [ti-misp] Fix event.original null scenario [ti_misp] Fix event.original null scenario Jul 20, 2023
@bhapas bhapas changed the title [ti_misp] Fix event.original null scenario [ti_misp] Skip rename if "event.original" already exists Jul 20, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-20T07:38:06.303+0000

  • Duration: 16 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jul 20, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 2.767
Classes 100.0% (2/2) 💚 2.767
Methods 100.0% (30/30) 💚 7.828
Lines 86.831% (633/729) 👎 -4.318
Conditionals 100.0% (0/0) 💚

taylor-swanson
taylor-swanson approved these changes Jul 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhapas bhapas merged commit 8e6fadb into elastic:main Jul 20, 2023
This was referenced Aug 25, 2023
Closed
Closed
@bhapas bhapas mentioned this pull request Sep 20, 2023
Merged
12 tasks
@jillguyonnet jillguyonnet mentioned this pull request Jan 11, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taylor-swanson taylor-swanson taylor-swanson approved these changes

Assignees

@bhapas bhapas

Labels

bugfix Pull request that fixes a bug issue Integration:ti_misp MISP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ti_misp] integration doesn't work if "event.original" already exists

3 participants

@bhapas @elasticmachine @taylor-swanson