[System Diskio] Remove duplicated fields in diskio data_stream#7006
Conversation
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
packages/system/changelog.yml
Outdated
| # newer versions go on top | ||
| - version: "1.38.1" | ||
| changes: | ||
| - description: Remove duplicated fields in diskio data_stream |
There was a problem hiding this comment.
Can you please revisit the changelog?
Shouldn't this be duplicated field mappings, datastream instead of data_stream?
Also, this change includes additional metric_type mappings. It may be good to add that part to the changelog description/
There was a problem hiding this comment.
Shouldn't this be duplicated field mappings,
in fields folder are defined fields that package provide, not the index mapping
datastream instead of data_stream?
folder name: packages/system/data_stream/diskio, so I used data_stream, if you want I can rename it to datastream. I don't have strong preference, please let me know
Also, this change includes additional metric_type mappings. It may be good to add that part to the changelog description/
Not sure, that it should be considered as adding metric_type mappings, since there were defined twice fields host.disk.read.bytes and host.disk.write.bytes - I've removed it from fields/fields.yml file (the one where metric_type was already added, but not affected the mapping as expected due to override) and merged it definition with the remaining host.disk.read.bytes and host.disk.write.bytes defined in fields/agent.yml.
There was a problem hiding this comment.
I don't have strong preference, please let me know
Please use datastream for consistency
Shouldn't this be duplicated field mappings,
in
fieldsfolder are defined fields that package provide, not the index mappingdatastream instead of data_stream?
folder name:
packages/system/data_stream/diskio, so I useddata_stream, if you want I can rename it todatastream. I don't have strong preference, please let me knowAlso, this change includes additional metric_type mappings. It may be good to add that part to the changelog description/
Not sure, that it should be considered as
adding metric_type mappings, since there were defined twice fieldshost.disk.read.bytesandhost.disk.write.bytes- I've removed it fromfields/fields.ymlfile (the one wheremetric_typewas already added, but not affected the mapping as expected due to override) and merged it definition with the remaininghost.disk.read.bytesandhost.disk.write.bytesdefined infields/agent.yml.
Yes, i understand.
There was a problem hiding this comment.
I don't have strong preference, please let me know
Please use datastream for consistency
done - bb6c1f3, please have a look
|
Package system - 1.38.1 containing this change is available at https://epr.elastic.co/search?package=system |
What does this PR do?
Remove duplicated fields in diskio data_stream
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots